linux-kernel - Re: [PATCH v2 04/21] dt-bindings: reset: renesas,rzv2h-usb2phy: Add '#mux-state-cells' property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aQ4p-XS_8ImhRRKN@tom-desktop>
Date: Fri, 7 Nov 2025 18:18:49 +0100
From: Tommaso Merciai <tommaso.merciai.xr@...renesas.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Philipp Zabel <p.zabel@...gutronix.de>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	biju.das.jz@...renesas.com, linux-phy@...ts.infradead.org,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	linux-renesas-soc@...r.kernel.org,
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>,
	tomm.merciai@...il.com, linux-kernel@...r.kernel.org,
	Vinod Koul <vkoul@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	Kishon Vijay Abraham I <kishon@...nel.org>,
	Arnd Bergmann <arnd@...db.de>, devicetree@...r.kernel.org,
	Magnus Damm <magnus.damm@...il.com>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
	Peter Rosin <peda@...ntia.se>
Subject: Re: [PATCH v2 04/21] dt-bindings: reset: renesas,rzv2h-usb2phy: Add
 '#mux-state-cells' property

Hi Rob,

On Wed, Nov 05, 2025 at 11:16:24AM -0600, Rob Herring (Arm) wrote:
> 
> On Wed, 05 Nov 2025 16:39:00 +0100, Tommaso Merciai wrote:
> > Add the '#mux-state-cells' property to the Renesas RZ/V2H(P) USB2PHY
> > reset binding to support describing the USB VBUS_SEL multiplexer as a
> > mux-controller.
> > 
> > This is required to properly configure the USB PHY power selection on
> > RZ/V2H(P), RZ/G3E SoCs.
> > 
> > Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@...renesas.com>
> > ---
> > v1->v2:
> >  - New patch
> > 
> >  .../bindings/reset/renesas,rzv2h-usb2phy-reset.yaml          | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/reset/renesas,rzv2h-usb2phy-reset.example.dtb: reset-controller@...30000 (renesas,r9a09g057-usb2phy-reset): $nodename:0: 'reset-controller@...30000' does not match '^mux-controller(@.*|-([0-9]|[1-9][0-9]+))?$'
> 	from schema $id: http://devicetree.org/schemas/mux/mux-controller.yaml

In v3 I will model mux controller as internal for the reset-controller:

	reset-controller@...30000 {
		compatible = "renesas,r9a09g057-usb2phy-reset";
	        reg = <0x15830000 0x10000>;
		clocks = <&cpg CPG_MOD 0xb6>;
	        resets = <&cpg 0xaf>;
		power-domains = <&cpg>;
	        #reset-cells = <0>;

		mux-controller {
	          #mux-state-cells = <1>;
		};
	};


Thanks & Regards,
Tommaso

> 
> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/961741af7d4ec945945164759fe0d78bb3cf4d9d.1762354366.git.tommaso.merciai.xr@bp.renesas.com
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>