| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20251107-matrimony-showdown-ba6ce6996b2f@spud>
Date: Fri, 7 Nov 2025 18:20:51 +0000
From: Conor Dooley <conor@...nel.org>
To: Frank Li <Frank.li@....com>
Cc: Support Opensource <support.opensource@...semi.com>,
Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Guenter Roeck <linux@...ck-us.net>,
Jonathan Cameron <Jonathan.Cameron@...wei.com>,
Michal Simek <michal.simek@....com>,
Wensheng Wang <wenswang@...h.net>,
Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>,
Nuno Sá <nuno.sa@...log.com>,
Naresh Solanki <naresh.solanki@...ements.com>,
Grant Peltier <grantpeltier93@...il.com>,
Vasileios Amoiridis <vassilisamir@...il.com>,
Dixit Parmar <dixitparmar19@...il.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>, imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: mfd: Convert dlg,da9052-i2c.txt to yaml
format
On Thu, Nov 06, 2025 at 02:22:10PM -0500, Frank Li wrote:
> On Thu, Nov 06, 2025 at 05:39:47PM +0000, Conor Dooley wrote:
> > On Wed, Nov 05, 2025 at 08:33:56PM -0500, Frank Li wrote:
> > > Convert dlg,da9052-i2c.txt to yaml format.
> > > Additional changes:
> > > - compatible string fallback to dlg,da9052 to align existing dts files.
> > > - Add interrupts property.
> > > - Add ref to /schemas/spi/spi-peripheral-props.yaml#
> > >
> > > Remove dlg,da9053 from trivial-devices.yaml.
> > >
> > > Signed-off-by: Frank Li <Frank.Li@....com>
> > > ---
> > > .../devicetree/bindings/mfd/da9052-i2c.txt | 67 -------------
> > > .../devicetree/bindings/mfd/dlg,da9052.yaml | 93 +++++++++++++++++++
> > > .../devicetree/bindings/trivial-devices.yaml | 2 -
> > > 3 files changed, 93 insertions(+), 69 deletions(-)
> > > delete mode 100644 Documentation/devicetree/bindings/mfd/da9052-i2c.txt
> > > create mode 100644 Documentation/devicetree/bindings/mfd/dlg,da9052.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/mfd/da9052-i2c.txt b/Documentation/devicetree/bindings/mfd/da9052-i2c.txt
> > > deleted file mode 100644
> > > index 07c69c0c6624c..0000000000000
> > > --- a/Documentation/devicetree/bindings/mfd/da9052-i2c.txt
> > > +++ /dev/null
> > > @@ -1,67 +0,0 @@
> > > -* Dialog DA9052/53 Power Management Integrated Circuit (PMIC)
> > > -
> > > -Required properties:
> > > -- compatible : Should be "dlg,da9052", "dlg,da9053-aa",
> > > - "dlg,da9053-ab", or "dlg,da9053-bb"
> > > -
> > > -Optional properties:
> > > -- dlg,tsi-as-adc : Boolean, if set the X+, X-, Y+, Y- touchscreen
> > > - input lines are used as general purpose analogue
> > > - input.
> > > -- tsiref-supply: Phandle to the regulator, which provides the reference
> > > - voltage for the TSIREF pin. Must be provided when the
> > > - touchscreen pins are used for ADC purposes.
> > > -
> > > -Sub-nodes:
> > > -- regulators : Contain the regulator nodes. The DA9052/53 regulators are
> > > - bound using their names as listed below:
> > > -
> > > - buck1 : regulator BUCK CORE
> > > - buck2 : regulator BUCK PRO
> > > - buck3 : regulator BUCK MEM
> > > - buck4 : regulator BUCK PERI
> > > - ldo1 : regulator LDO1
> > > - ldo2 : regulator LDO2
> > > - ldo3 : regulator LDO3
> > > - ldo4 : regulator LDO4
> > > - ldo5 : regulator LDO5
> > > - ldo6 : regulator LDO6
> > > - ldo7 : regulator LDO7
> > > - ldo8 : regulator LDO8
> > > - ldo9 : regulator LDO9
> > > - ldo10 : regulator LDO10
> > > -
> > > - The bindings details of individual regulator device can be found in:
> > > - Documentation/devicetree/bindings/regulator/regulator.txt
> > > -
> > > -Examples:
> > > -
> > > -i2c@...c8000 { /* I2C1 */
> > > -
> > > - pmic: dialog@48 {
> > > - compatible = "dlg,da9053-aa";
> > > - reg = <0x48>;
> > > -
> > > - regulators {
> > > - buck1 {
> > > - regulator-min-microvolt = <500000>;
> > > - regulator-max-microvolt = <2075000>;
> > > - };
> > > -
> > > - buck2 {
> > > - regulator-min-microvolt = <500000>;
> > > - regulator-max-microvolt = <2075000>;
> > > - };
> > > -
> > > - buck3 {
> > > - regulator-min-microvolt = <925000>;
> > > - regulator-max-microvolt = <2500000>;
> > > - };
> > > -
> > > - buck4 {
> > > - regulator-min-microvolt = <925000>;
> > > - regulator-max-microvolt = <2500000>;
> > > - };
> > > - };
> > > - };
> > > -};
> > > diff --git a/Documentation/devicetree/bindings/mfd/dlg,da9052.yaml b/Documentation/devicetree/bindings/mfd/dlg,da9052.yaml
> > > new file mode 100644
> > > index 0000000000000..4ecd498864e4e
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/mfd/dlg,da9052.yaml
> > > @@ -0,0 +1,93 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/mfd/dlg,da9052.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Dialog DA9052/53 Power Management Integrated Circuit (PMIC)
> > > +
> > > +maintainers:
> > > + - Frank Li <Frank.Li@....com>
> > > +
> > > +properties:
> > > + compatible:
> > > + oneOf:
> > > + - items:
> > > + - enum:
> > > + - dlg,da9053
> >
> > Should this actually exist? It was never in any drivers etc at all, and
> > as far as I can tell any users use the -XX suffixed ones. Probably this
> > is the only compatible that /should/ have been used, but it might be
> > pointless to add now.
>
> A old dts arch/arm/boot/dts/nxp/imx/imx53-smd.dts use "dlg,da9053", "dlg,da9052"
Given my observations about the fallback below, I think this one should
be changed in the dts to whatever dlg,da9053-XX variant it actually is.
> > > + - dlg,da9053-aa
> > > + - dlg,da9053-ab
> > > + - dlg,da9053-bb
> >
> > The driver also has a bc, I think that should be added.
> >
> > > + - const: dlg,da9052
> >
> > Is this actually a correct fallback?
> > I know it is being used, but looking at the drivers I see things like:
> > /* Select the appropriate current limit range */
> > if (regulator->da9052->chip_id == DA9052)
> > row = 0;
> > else if (offset == 0)
> > row = 1;
> > in both the battery and regulator drivers.
> > Might actually be the devicetrees are wrong here?
>
> Ideally, not fallback to dlg,da9052, but need update old dts file to clean
> up warning.
>
> If you prefer this way, I can remove fallback and update dts files.
Yeah, I think so. If the things need different current limits I don't
think that the fallback is really suitable.
> > > + - enum:
> > > + - dlg,da9052
> > > + - dlg,da9053-aa # Just for match existed old platform
> >
> > Could you just change that one old platform using it?
>
> Yes
And since we are removing the da9052 fallback, this comment can be
removed and the old platform can stay as it is.
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists