linux-kernel - Re: [PATCH] RDMA/core: Fix uninitialized gid in ib_nl_process_good_ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251107191736.GC1859178@ziepe.ca>
Date: Fri, 7 Nov 2025 15:17:36 -0400
From: Jason Gunthorpe <jgg@...pe.ca>
To: Vlad Dumitrescu <vdumitrescu@...dia.com>
Cc: Kriish Sharma <kriish.sharma2006@...il.com>,
	Leon Romanovsky <leon@...nel.org>, Parav Pandit <parav@...dia.com>,
	Edward Srouji <edwards@...dia.com>, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	syzbot+938fcd548c303fe33c1a@...kaller.appspotmail.com
Subject: Re: [PATCH] RDMA/core: Fix uninitialized gid in
 ib_nl_process_good_ip_rsep()

On Fri, Nov 07, 2025 at 11:11:40AM -0800, Vlad Dumitrescu wrote:
> On 11/7/25 07:37, Jason Gunthorpe wrote: 
> > The fix to whatever this is should be in ib_nl_is_good_ip_resp().
> 
> nla_parse_deprecated returns success if attrs are missing?
> 
> Other callers also check for their expected attrs to be present in tb,
> after checking nla_parse_deprecated()'s return code.

That sounds like the trouble then, the check for tb presence should be
added to the ib_nl_is_good_ip_resp..

Jason