linux-kernel - Re: [PATCH 02/11] ntfsplus: add super block operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKYAXd-YiCdiHn8ZrwisB=5A_u2fXCDPVvmZFc9n6nHf3JF_7A@mail.gmail.com>
Date: Fri, 7 Nov 2025 11:58:19 +0900
From: Namjae Jeon <linkinjeon@...nel.org>
To: Mobin Aydinfar <mobin@...intestserver.ir>
Cc: viro@...iv.linux.org.uk, brauner@...nel.org, hch@...radead.org, hch@....de, 
	tytso@....edu, willy@...radead.org, jack@...e.cz, djwong@...nel.org, 
	josef@...icpanda.com, sandeen@...deen.net, rgoldwyn@...e.com, 
	xiang@...nel.org, dsterba@...e.com, pali@...nel.org, ebiggers@...nel.org, 
	neil@...wn.name, amir73il@...il.com, linux-fsdevel@...r.kernel.org, 
	linux-kernel@...r.kernel.org, iamjoonsoo.kim@....com, cheol.lee@....com, 
	jay.sim@....com, gunho.lee@....com
Subject: Re: [PATCH 02/11] ntfsplus: add super block operations

On Fri, Nov 7, 2025 at 5:03 AM Mobin Aydinfar <mobin@...intestserver.ir> wrote:
>
Hi Mobin,
> Hi Namjae, I built your new driver (as DKMS) and I'm using it and it
> went smooth so far. Thanks for this good driver (and also really
> practical userspace tools) but something in dmesg caught my eye:
Thanks for your test:)
>
> On 10/20/25 05:37, Namjae Jeon wrote:
> > This adds the implementation of superblock operations for ntfsplus.
> >
> > Signed-off-by: Namjae Jeon <linkinjeon@...nel.org>
> > ---
> >   fs/ntfsplus/super.c | 2716 +++++++++++++++++++++++++++++++++++++++++++
> >   1 file changed, 2716 insertions(+)
> >   create mode 100644 fs/ntfsplus/super.c
> >
> > diff --git a/fs/ntfsplus/super.c b/fs/ntfsplus/super.c
> > new file mode 100644
> > index 000000000000..1803eeec5618
> > --- /dev/null
> > +++ b/fs/ntfsplus/super.c
> > @@ -0,0 +1,2716 @@
> > ...
> > +     pr_info("volume version %i.%i, dev %s, cluster size %d\n",
> > +             vol->major_ver, vol->minor_ver, sb->s_id, vol->cluster_size);
> > +
>  > ...
>
> Shouldn't pr_info() messages have "ntfsplus: " prefix? I mean most
> drivers do so and it is weird to me to have something like this:
>
> [    5.431662] volume version 3.1, dev sda3, cluster size 4096
> [    5.444801] volume version 3.1, dev sdb1, cluster size 4096
>
> instead of this:
>
> [    5.431662] ntfsplus: volume version 3.1, dev sda3, cluster size 4096
> [    5.444801] ntfsplus: volume version 3.1, dev sdb1, cluster size 4096
>
> in my dmesg. What do you think? It wouldn't be better to include
> "ntfsplus: " prefix for pr_info messages?
Okay, I will improve it in the next version.
Thanks.
>
> Best Regards