linux-kernel - [PATCH] drm/rcar-du: dsi: Handle both DRM_MODE_FLAG_N.SYNC and !DRM_MODE_FLAG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251107230419.471866-1-marek.vasut+renesas@mailbox.org>
Date: Sat,  8 Nov 2025 00:04:10 +0100
From: Marek Vasut <marek.vasut+renesas@...lbox.org>
To: dri-devel@...ts.freedesktop.org
Cc: Marek Vasut <marek.vasut+renesas@...lbox.org>,
	David Airlie <airlied@...il.com>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
	Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Magnus Damm <magnus.damm@...il.com>,
	Maxime Ripard <mripard@...nel.org>,
	Simona Vetter <simona@...ll.ch>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com>,
	linux-kernel@...r.kernel.org,
	linux-renesas-soc@...r.kernel.org
Subject: [PATCH] drm/rcar-du: dsi: Handle both DRM_MODE_FLAG_N.SYNC and !DRM_MODE_FLAG_P.SYNC

Since commit 94fe479fae96 ("drm/rcar-du: dsi: Clean up handling of DRM mode flags")
the driver does not set TXVMVPRMSET0R_VSPOL_LOW and TXVMVPRMSET0R_HSPOL_LOW
for modes which set neither DRM_MODE_FLAG_[PN].SYNC. The previous behavior
was to assume that neither flag means DRM_MODE_FLAG_N.SYNC . Restore the
previous behavior for maximum compatibility.

Fixes: 94fe479fae96 ("drm/rcar-du: dsi: Clean up handling of DRM mode flags")
Signed-off-by: Marek Vasut <marek.vasut+renesas@...lbox.org>
---
Cc: David Airlie <airlied@...il.com>
Cc: Geert Uytterhoeven <geert+renesas@...der.be>
Cc: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
Cc: Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>
Cc: Magnus Damm <magnus.damm@...il.com>
Cc: Maxime Ripard <mripard@...nel.org>
Cc: Simona Vetter <simona@...ll.ch>
Cc: Thomas Zimmermann <tzimmermann@...e.de>
Cc: Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com>
Cc: dri-devel@...ts.freedesktop.org
Cc: linux-kernel@...r.kernel.org
Cc: linux-renesas-soc@...r.kernel.org
---
 drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c b/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c
index 9413b76d0bfce..98bd7f40adbea 100644
--- a/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c
+++ b/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c
@@ -492,9 +492,11 @@ static void rcar_mipi_dsi_set_display_timing(struct rcar_mipi_dsi *dsi,
 
 	/* Configuration for Video Parameters, input is always RGB888 */
 	vprmset0r = TXVMVPRMSET0R_BPP_24;
-	if (mode->flags & DRM_MODE_FLAG_NVSYNC)
+	if ((mode->flags & DRM_MODE_FLAG_NVSYNC) ||
+	    !(mode->flags & DRM_MODE_FLAG_PVSYNC))
 		vprmset0r |= TXVMVPRMSET0R_VSPOL_LOW;
-	if (mode->flags & DRM_MODE_FLAG_NHSYNC)
+	if ((mode->flags & DRM_MODE_FLAG_NHSYNC) ||
+	    !(mode->flags & DRM_MODE_FLAG_PHSYNC))
 		vprmset0r |= TXVMVPRMSET0R_HSPOL_LOW;
 
 	vprmset1r = TXVMVPRMSET1R_VACTIVE(mode->vdisplay)
-- 
2.51.0