linux-kernel - Re: [PATCH] ASoC: fsl: fsl_ssi: Replace deprecated strcpy() with strscpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fc28b6c4-3495-0581-1dad-41e49ae86917@gmail.com>
Date: Fri, 7 Nov 2025 10:04:13 +0530 (IST)
From: HariKrishna Sagala <hariconscious@...il.com>
To: Shuah Khan <skhan@...uxfoundation.org>, hariconscious@...il.com, 
    shengjiu.wang@...il.com, Xiubo.Lee@...il.com, festevam@...il.com, 
    nicoleotsuka@...il.com, lgirdwood@...il.com, broonie@...nel.org, 
    perex@...ex.cz, tiwai@...e.com
cc: khalid@...nel.org, shuah@...nel.org, david.hunter.linux@...il.com, 
    linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: fsl: fsl_ssi: Replace deprecated strcpy() with
 strscpy()



On Thu, 6 Nov 2025, Shuah Khan wrote:

> On 11/4/25 22:21, hariconscious@...il.com wrote:
> > From: HariKrishna Sagala <hariconscious@...il.com>
> >
> > strcpy() is deprecated,use strscpy() instead.
> > No functional changes intended.
> > Link: https://github.com/KSPP/linux/issues/88
> >
> > Signed-off-by: HariKrishna Sagala <hariconscious@...il.com>
> > ---
> > This patch replaces strcpy() call with the strscpy() API.
> > strscpy() is preferred over strcpy()/strncpy() as per the
> > kernel documentation.
>
> Which kernel documentation and can you add why strscpy() ie
> better than strcpy() instead saying "as per the kernel documentation."
> >
> > Thank you.
> >
> >   sound/soc/fsl/fsl_ssi.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
> > index 320108bebf30..b2e1da1781ae 100644
> > --- a/sound/soc/fsl/fsl_ssi.c
> > +++ b/sound/soc/fsl/fsl_ssi.c
> > @@ -1447,7 +1447,7 @@ static int fsl_ssi_probe_from_dt(struct fsl_ssi *ssi)
> >   			dev_err(dev, "failed to get SSI index property\n");
> >   			return -EINVAL;
> >   		}
> > -		strcpy(ssi->card_name, "ac97-codec");
> > +		strscpy(ssi->card_name, "ac97-codec");
> >   	} else if (!of_property_read_bool(np, "fsl,ssi-asynchronous")) {
> >   		/*
> >   		 * In synchronous mode, STCK and STFS ports are used by RX
> >
> > base-commit: 284922f4c563aa3a8558a00f2a05722133237fe8
>
> thanks,
> -- Shuah
>
Please find the below reference links.
https://github.com/KSPP/linux/issues/88
https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy
Thank you.