linux-kernel - Re: [PATCH 2/2] iommupt: Describe @bitnr parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251107003541.GA1792527@ziepe.ca>
Date: Thu, 6 Nov 2025 20:35:41 -0400
From: Jason Gunthorpe <jgg@...pe.ca>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: Bagas Sanjaya <bagasdotme@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux Documentation <linux-doc@...r.kernel.org>,
	Linux IOMMU <iommu@...ts.linux.dev>,
	Jonathan Corbet <corbet@....net>, Joerg Roedel <joro@...tes.org>,
	Will Deacon <will@...nel.org>, Robin Murphy <robin.murphy@....com>,
	Samiullah Khawaja <skhawaja@...gle.com>,
	Kevin Tian <kevin.tian@...el.com>,
	Lu Baolu <baolu.lu@...ux.intel.com>,
	Pasha Tatashin <pasha.tatashin@...een.com>
Subject: Re: [PATCH 2/2] iommupt: Describe @bitnr parameter

On Thu, Nov 06, 2025 at 03:48:10PM -0800, Randy Dunlap wrote:
> > diff --git a/drivers/iommu/generic_pt/pt_common.h b/drivers/iommu/generic_pt/pt_common.h
> > index b5628f47e0db40..54c16355be2842 100644
> > --- a/drivers/iommu/generic_pt/pt_common.h
> > +++ b/drivers/iommu/generic_pt/pt_common.h
> > @@ -354,6 +354,7 @@ static inline unsigned int pt_max_sw_bit(struct pt_common *common);
> >  /**
> >   * pt_test_sw_bit_acquire() - Read a software bit in an item
> >   * @pts: Entry to set
> > + * @bitnr: Bit to set
> 
> Shouldn't both of these (above) to "to read" instead of "to set"?

Yes, that's right, Bagas could you fold that into a v2?

Jason