linux-kernel - Re: [PATCH v2] i2c: designware: Replace magic numbers with named constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202511071402.qHS6LLi9-lkp@intel.com>
Date: Fri, 7 Nov 2025 14:54:24 +0800
From: kernel test robot <lkp@...el.com>
To: Artem Shimko <a.shimko.dev@...il.com>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Jan Dabros <jsd@...ihalf.com>, Andi Shyti <andi.shyti@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev, Artem Shimko <a.shimko.dev@...il.com>,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] i2c: designware: Replace magic numbers with named
 constants

Hi Artem,

kernel test robot noticed the following build errors:

[auto build test ERROR on andi-shyti/i2c/i2c-host]
[also build test ERROR on westeri-thunderbolt/next linus/master v6.18-rc4 next-20251107]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Artem-Shimko/i2c-designware-Replace-magic-numbers-with-named-constants/20251107-000812
base:   https://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git i2c/i2c-host
patch link:    https://lore.kernel.org/r/20251106160206.2617785-1-a.shimko.dev%40gmail.com
patch subject: [PATCH v2] i2c: designware: Replace magic numbers with named constants
config: loongarch-randconfig-001-20251107 (https://download.01.org/0day-ci/archive/20251107/202511071402.qHS6LLi9-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251107/202511071402.qHS6LLi9-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511071402.qHS6LLi9-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/i2c/busses/i2c-designware-common.c: In function 'i2c_dw_set_fifo_size':
>> drivers/i2c/busses/i2c-designware-common.c:712:25: error: implicit declaration of function 'FIELD_GET' [-Wimplicit-function-declaration]
     712 |         tx_fifo_depth = FIELD_GET(DW_IC_FIFO_TX_FIELD, param) + 1;
         |                         ^~~~~~~~~


vim +/FIELD_GET +712 drivers/i2c/busses/i2c-designware-common.c

   684	
   685	int i2c_dw_set_fifo_size(struct dw_i2c_dev *dev)
   686	{
   687		u32 tx_fifo_depth, rx_fifo_depth;
   688		unsigned int param;
   689		int ret;
   690	
   691		/* DW_IC_COMP_PARAM_1 not implement for IP issue */
   692		if ((dev->flags & MODEL_MASK) == MODEL_WANGXUN_SP) {
   693			dev->tx_fifo_depth = TXGBE_TX_FIFO_DEPTH;
   694			dev->rx_fifo_depth = TXGBE_RX_FIFO_DEPTH;
   695	
   696			return 0;
   697		}
   698	
   699		/*
   700		 * Try to detect the FIFO depth if not set by interface driver,
   701		 * the depth could be from 2 to 256 from HW spec.
   702		 */
   703		ret = i2c_dw_acquire_lock(dev);
   704		if (ret)
   705			return ret;
   706	
   707		ret = regmap_read(dev->map, DW_IC_COMP_PARAM_1, &param);
   708		i2c_dw_release_lock(dev);
   709		if (ret)
   710			return ret;
   711	
 > 712		tx_fifo_depth = FIELD_GET(DW_IC_FIFO_TX_FIELD, param) + 1;
   713		rx_fifo_depth = FIELD_GET(DW_IC_FIFO_RX_FIELD, param) + 1;
   714		if (!dev->tx_fifo_depth) {
   715			dev->tx_fifo_depth = tx_fifo_depth;
   716			dev->rx_fifo_depth = rx_fifo_depth;
   717		} else if (tx_fifo_depth >= DW_IC_FIFO_MIN_DEPTH) {
   718			dev->tx_fifo_depth = min_t(u32, dev->tx_fifo_depth,
   719					tx_fifo_depth);
   720			dev->rx_fifo_depth = min_t(u32, dev->rx_fifo_depth,
   721					rx_fifo_depth);
   722		}
   723	
   724		return 0;
   725	}
   726	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki