linux-kernel - Re: [PATCH] bpf: hashtab: fix 32-bit overflow in memory usage calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALOAHbDYOx_BChfKuaDVuaxjWt9ixPSO_0x=LuuzNLeEXDuvFA@mail.gmail.com>
Date: Fri, 7 Nov 2025 15:42:44 +0800
From: Yafang Shao <laoar.shao@...il.com>
To: Алексей Сафин <a.safin@...a.ru>
Cc: Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, 
	Andrii Nakryiko <andrii@...nel.org>, Martin KaFai Lau <martin.lau@...ux.dev>, 
	Eduard Zingerman <eddyz87@...il.com>, Song Liu <song@...nel.org>, 
	Yonghong Song <yonghong.song@...ux.dev>, John Fastabend <john.fastabend@...il.com>, 
	KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>, Hao Luo <haoluo@...gle.com>, 
	Jiri Olsa <jolsa@...nel.org>, bpf@...r.kernel.org, linux-kernel@...r.kernel.org, 
	lvc-patches@...uxtesting.org, stable@...r.kernel.org
Subject: Re: [PATCH] bpf: hashtab: fix 32-bit overflow in memory usage calculation

On Fri, Nov 7, 2025 at 2:58 PM Алексей Сафин <a.safin@...a.ru> wrote:
>
> Yes, that looks even better to me. Changing value_size to u64 at declaration
> makes the arithmetic safe everywhere and keeps the code cleaner.
>
> I agree with this version.
>
> Should I prepare a v2 patch with this modification, or will you take it
> from here?

Pls send a v2

-- 
Regards
Yafang