linux-kernel - Re: [RESEND PATCH v2 2/5] dt-bindings: mfd: syscon: Add ti,am625-dss-clk-ctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a40e8329-0423-49a9-8675-3a3ecb9c9134@kernel.org>
Date: Fri, 7 Nov 2025 08:56:50 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Swamil Jain <s-jain1@...com>
Cc: jyri.sarha@....fi, tomi.valkeinen@...asonboard.com,
 maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de,
 airlied@...il.com, simona@...ll.ch, nm@...com, vigneshr@...com,
 kristo@...nel.org, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 lee@...nel.org, louis.chauvet@...tlin.com, aradhya.bhatia@...ux.dev,
 devarsht@...com, praneeth@...com, h-shenoy@...com,
 dri-devel@...ts.freedesktop.org, linux-arm-kernel@...ts.infradead.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH v2 2/5] dt-bindings: mfd: syscon: Add
 ti,am625-dss-clk-ctrl

On 07/11/2025 08:50, Krzysztof Kozlowski wrote:
> On Thu, Nov 06, 2025 at 07:42:24PM +0530, Swamil Jain wrote:
>> From: Louis Chauvet <louis.chauvet@...tlin.com>
>>
>> The dt-bindings for the multi-function device (mfd) syscon need to include
>> ti,am625-dss-clk-ctrl. On AM62X, AM62A and AM62P devicess, the display
>> controller (tidss) has external registers to control certain clock
>> properties. These registers are located in the device configuration
>> registers, so they need to be declared using syscon. They will later be
>> used with a phandle in the tidss node.
>>
>> Fixes: ad2ac9dc9426 ("drm/tidss: Add support for AM625 DSS")
>> Fixes: 5cc5ea7b6d7b ("drm/tidss: Add support for AM62A7 DSS")
> 
> Adding missing hardware is not a fix. Drop both.
> 
>> Cc: stable@...r.kernel.org
> 
> For sure not a stable commit. You just add new hardware.
> 
>> Signed-off-by: Louis Chauvet <louis.chauvet@...tlin.com>
>> Signed-off-by: Swamil Jain <s-jain1@...com>
>> ---
>>  Documentation/devicetree/bindings/mfd/syscon.yaml | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> With these fixed/dropped:
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Un-acked, NAK.

You just ignored previous feedback.

Best regards,
Krzysztof