linux-kernel - Re: [PATCH v2] dt-bindings: usb: maxim,max3421: convert to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251107-agile-alligator-of-philosophy-03d923@kuoka>
Date: Fri, 7 Nov 2025 09:03:54 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>
Cc: gregkh@...uxfoundation.org, robh@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org, davidm@...uge.net, ~lkcamp/patches@...ts.sr.ht, 
	linux-usb@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] dt-bindings: usb: maxim,max3421: convert to DT schema

On Thu, Nov 06, 2025 at 09:06:22PM -0300, Rodrigo Gobbi wrote:
> Convert legacy maxim,max3421.txt to proper format.
> 
> Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>
> ---
> Hi, all
> 
> At this v2, I`m reverting my previous idea about documenting new properties
> because this is just a conversion from txt file. At v1, a question
> was raised about that:
> 
> On 10/9/25 22:34, Krzysztof Kozlowski wrote:
> > maxim,vbus-en-pin, maxim,gpx-pin, reset pin and supplies. Also add a
> > Why new properties? You must explain not only the difference but WHY you
> > are doing this.
> In this case, I`ve kept the maxim,vbus-en-pin prop because it was already
> described in the legacy file and the driver expects that property according
> to [1] and [2].

This is not a commit msg. Apply this patch from the lists and look
whether the information is there.

So again:

You commit msg explain any unusual changes - like modifying binding
while ONLY converting it - and WHY you are doing the unusual changes.

Best regards,
Krzysztof