linux-kernel - Re: [PATCH 0/6] of: iommu-map parsing for multi-cell IOMMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251107-active-uber-impala-8d9118@kuoka>
Date: Fri, 7 Nov 2025 09:07:05 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Charan Teja Kalla <charan.kalla@....qualcomm.com>
Cc: robin.murphy@....com, will@...nel.org, joro@...tes.org, 
	robh@...nel.org, dmitry.baryshkov@....qualcomm.com, 
	konrad.dybcio@....qualcomm.com, bjorn.andersson@....qualcomm.com, bod@...nel.org, 
	conor+dt@...nel.org, krzk+dt@...nel.org, saravanak@...gle.com, 
	prakash.gupta@....qualcomm.com, vikash.garodia@....qualcomm.com, iommu@...ts.linux.dev, 
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 0/6] of: iommu-map parsing for multi-cell IOMMU

On Tue, Nov 04, 2025 at 02:20:59PM +0530, Charan Teja Kalla wrote:
> The iommu-map property has been defined for the PCIe usecase and has
> been hardcoded to assume single cell for IOMMU specification, ignoring
> the #iommu-cells completely. Since the initial definition the iommu-maps
> property has been reused for other usecases and we can no longer assume
> that the single IOMMU cell properly describes the necessary IOMMU
> streams. Expand the iommu-map to take #iommu-cells into account, while
> keeping the compatibility with the existing DTs, which assume single
> argument. 
> 
> Unlike single iommu-cell, it is complex to establish a linear relation
> between input 'id' and output specifier for multi iommu-cells. To handle
> such cases, rely on arch-specific drivers called through
> of_iommu_xlate() from of_iommu layer, aswell it is expected the 'len'
> passed is always 1. In the of_iommu layer, the below relation is
> established before calling into vendor specific driver: 
> 
> a) For platform devices, 'rid' defined in the iommu-map tuple indicates
> a function, through a bit position, which is compared against passed
> input 'id' that represents a bitmap of functions represented by the
> device.
> 
> b) For others, 'rid' is compared against the input 'id' as an integer
> value.
> 
> Thus the final representation when #iommu-cells=n is going to be,
> iommu-map = <rid/functionid IOMMU_phandle cell0 .. celln len>;, where
> len = 1.
> 
> The RFC for this patch set is found at [2].

So that's a v2 or v3? Then number your patchsets correctly.

Try yourself -  b4 diff cover.1762235099.git.charan.kalla@....qualcomm.com

Works? No.

Where is the changelog?

Best regards,
Krzysztof