linux-kernel - Re: [PATCH v2 5/5] remoteproc: imx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEnQRZDcrWdAFqJkcbjy-jL=EczgmSM9grv5zp6bntWnqou_kQ@mail.gmail.com>
Date: Fri, 7 Nov 2025 11:13:59 +0200
From: Daniel Baluta <daniel.baluta@...il.com>
To: Peng Fan <peng.fan@....com>
Cc: Bjorn Andersson <andersson@...nel.org>, Mathieu Poirier <mathieu.poirier@...aro.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, 
	Pengutronix Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, 
	Daniel Baluta <daniel.baluta@....com>, Frank Li <frank.li@....com>, 
	linux-remoteproc@...r.kernel.org, devicetree@...r.kernel.org, 
	imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 5/5] remoteproc: imx_rproc: Add support for i.MX95

On Fri, Oct 31, 2025 at 4:27 AM Peng Fan <peng.fan@....com> wrote:
>
> Add imx_rproc_cfg_imx95_m7 and address(TCM and DDR) mapping.
> Add i.MX95 of_device_id entry.
>
> Signed-off-by: Peng Fan <peng.fan@....com>

With the minor comment below, you can add my:

Reviewed-by: Daniel Baluta <daniel.baluta@....com>

<snip>

> +static const struct imx_rproc_dcfg imx_rproc_cfg_imx95_m7 = {
> +       .att            = imx_rproc_att_imx95_m7,
> +       .att_size       = ARRAY_SIZE(imx_rproc_att_imx95_m7),
> +       .ops            = &imx_rproc_ops_sm,
> +       /* Must align with System Manager Firmware */

I would add a comment here like this:

> +       .cpuid          = 1, /* Use 1 as default cpu id for M7 core */
> +       .lmid           = 1, /* Use 1 as default Logical Machine where M7 resides */
> +};
> +