lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <aQ25Ix2V_8IMc_8y@google.com>
Date: Fri, 7 Nov 2025 09:17:23 +0000
From: Alice Ryhl <aliceryhl@...gle.com>
To: Hang Shu <m18080292938@....com>
Cc: ojeda@...nel.org, Hang Shu <hangshu847@...il.com>, 
	Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>, 
	Gary Guo <gary@...yguo.net>, 
	"Björn Roy Baron" <bjorn3_gh@...tonmail.com>, Benno Lossin <lossin@...nel.org>, 
	Andreas Hindborg <a.hindborg@...nel.org>, Trevor Gross <tmgross@...ch.edu>, 
	Danilo Krummrich <dakr@...nel.org>, Yutaro Ohno <yutaro.ono.418@...il.com>, 
	"Onur Özkan" <work@...rozkan.dev>, Borys Tyran <borys.tyran@...tonmail.com>, 
	Charalampos Mitrodimas <charmitro@...teo.net>, Daniel Sedlak <daniel@...lak.dev>, 
	Tamir Duberstein <tamird@...il.com>, Matt Gilbride <mattgilbride@...gle.com>, 
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust: correct documentation comment for rbtree cursor
 peek_next method

On Fri, Nov 07, 2025 at 02:47:16AM +0000, Hang Shu wrote:
> From: Hang Shu <hangshu847@...il.com>
> 
> The peek_next method's doc comment incorrectly stated it accesses the
> "previous" node when it actually accesses the next node. This commit
> fixes the documentation to accurately reflect the method's behavior.
> 
> Fixes: 98c14e40e07a ("rust: rbtree: add cursor")
> Signed-off-by: Hang Shu <hangshu847@...il.com>

I shared a Reviewed-by tag for the first version, so please include it
in the commit message when sending a new version. That way, I don't have
to review the same code twice.

Also, this should say [PATCH v2] in the subject since it's version 2 of
this patch.

Alice

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ