linux-kernel - Re: [PATCH 13/13] soc: tegra: Simplify with of_machine_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58ec9a04-8f1f-4367-84b7-698348690df0@nvidia.com>
Date: Fri, 7 Nov 2025 10:41:56 +0000
From: Jon Hunter <jonathanh@...dia.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Rob Herring <robh@...nel.org>, Saravana Kannan <saravanak@...gle.com>,
 "Rafael J. Wysocki" <rafael@...nel.org>,
 Viresh Kumar <viresh.kumar@...aro.org>,
 Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Yangtao Li <tiny.windzz@...il.com>, Chen-Yu Tsai <wens@...nel.org>,
 Jernej Skrabec <jernej.skrabec@...il.com>,
 Samuel Holland <samuel@...lland.org>,
 Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Daniel Lezcano <daniel.lezcano@...aro.org>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Thomas Gleixner
 <tglx@...utronix.de>, Nicolas Ferre <nicolas.ferre@...rochip.com>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>,
 Claudiu Beznea <claudiu.beznea@...on.dev>,
 Maximilian Luz <luzmaximilian@...il.com>, Hans de Goede <hansg@...nel.org>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 Daniel Lezcano <daniel.lezcano@...nel.org>,
 Thierry Reding <thierry.reding@...il.com>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-pm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
 linux-arm-msm@...r.kernel.org, platform-driver-x86@...r.kernel.org,
 linux-tegra@...r.kernel.org
Subject: Re: [PATCH 13/13] soc: tegra: Simplify with of_machine_device_match()

On 06/11/2025 19:07, Krzysztof Kozlowski wrote:
> Replace open-coded getting root OF node and matching against it with
> new of_machine_device_match() helper.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> ---
> 
> Depends on the first OF patch.
> ---
>   drivers/soc/tegra/common.c | 12 +-----------
>   1 file changed, 1 insertion(+), 11 deletions(-)
> 
> diff --git a/drivers/soc/tegra/common.c b/drivers/soc/tegra/common.c
> index dff6d5ef4e46..d82b7670abb7 100644
> --- a/drivers/soc/tegra/common.c
> +++ b/drivers/soc/tegra/common.c
> @@ -27,17 +27,7 @@ static const struct of_device_id tegra_machine_match[] = {
>   
>   bool soc_is_tegra(void)
>   {
> -	const struct of_device_id *match;
> -	struct device_node *root;
> -
> -	root = of_find_node_by_path("/");
> -	if (!root)
> -		return false;
> -
> -	match = of_match_node(tegra_machine_match, root);
> -	of_node_put(root);
> -
> -	return match != NULL;
> +	return of_machine_device_match(tegra_machine_match);
>   }
>   
>   static int tegra_core_dev_init_opp_state(struct device *dev)
> 

Looks good to me ...

Reviewed-by: Jon Hunter <jonathanh@...dia.com>

Thanks
Jon

-- 
nvpublic