linux-kernel - Re: [PATCH v2 3/3] spi: add support for microchip "soft" spi controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <427e0f16-0055-47d8-981e-7bc91ad71bfc@microchip.com>
Date: Fri, 7 Nov 2025 10:52:23 +0000
From: Prajna Rajendra Kumar <prajna.rajendrakumar@...rochip.com>
To: Conor Dooley <conor@...nel.org>, Mark Brown <broonie@...nel.org>
CC: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	<linux-riscv@...ts.infradead.org>, <linux-spi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>, Conor Dooley
	<conor.dooley@...rochip.com>, Daire McNamara <daire.mcnamara@...rochip.com>,
	Valentina Fernandez Alanis <valentina.fernandezalanis@...rochip.com>, "Cyril
 Jean" <cyril.jean@...rochip.com>
Subject: Re: [PATCH v2 3/3] spi: add support for microchip "soft" spi
 controller

On 06/11/2025 17:50, Conor Dooley wrote:
> On Wed, Nov 05, 2025 at 04:18:30PM +0000, Mark Brown wrote:
>> On Wed, Nov 05, 2025 at 03:28:23PM +0000, Prajna Rajendra Kumar wrote:
>>
>>>   drivers/spi/Kconfig              |   9 +
>>>   drivers/spi/Makefile             |   1 +
>>>   drivers/spi/spi-microchip-core.c | 442 +++++++++++++++++++++++++++++++
>>>   3 files changed, 452 insertions(+)
>>> +config SPI_MICROCHIP_CORE
>>> +	tristate "Microchip FPGA SPI controllers"
>>> +	depends on SPI_MASTER
>> Reusing the same filename and config symbol is almost certainly going to
>> create issues and confusion for people upgrading their kernel or doing
>> backports.  Perhaps CoreSPI instead?
> The qspi driver (which is shared between SoC and FPGA IP) uses
> SPI_MICROCHIP_CORE_QSPI, so probably SPI_MICROCHIP_CORE_SPI should be
> used here. Prajna?

Hi Mark, Conor,

Thanks for the feedback. I’ll update the filename and config symbol to 
use SPI_MICROCHIP_CORE_SPI in the next version.

Best regards,
Prajna