linux-kernel - Re: (subset) [PATCH v2 1/4] mfd: simple-mfd-i2c: remove select I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <71DB25E553BE0B04+aQ1LlKzeR-FkZA83@kernel.org>
Date: Fri, 7 Nov 2025 09:29:56 +0800
From: Troy Mitchell <troy.mitchell@...ux.spacemit.com>
To: Lee Jones <lee@...nel.org>, Yixun Lan <dlan@...too.org>,
	Alex Elder <elder@...cstar.com>, Andi Shyti <andi.shyti@...nel.org>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Troy Mitchell <troy.mitchell@...ux.spacemit.com>
Cc: linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
	spacemit@...ts.linux.dev, linux-i2c@...r.kernel.org,
	linux-rtc@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: (subset) [PATCH v2 1/4] mfd: simple-mfd-i2c: remove select I2C_K1

On Thu, Nov 06, 2025 at 04:04:21PM +0000, Lee Jones wrote:
> On Mon, 27 Oct 2025 13:48:05 +0800, Troy Mitchell wrote:
> > select will force a symbol to a specific value without considering
> > its dependencies. As a result, the i2c-k1 driver will fail to build
> > when OF or COMMON_CLK are disabled.
> > 
> > The reason for removing I2C_K1 instead of adding a depends on condition
> > is to keep the possibility for other SoCs to use this PMIC.
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/4] mfd: simple-mfd-i2c: remove select I2C_K1
>       commit: ecf6bc474ae97c404e2125b413eb0ef3627b03c5
Hi Lee,

I think you didn't notice this reply [1]
(Maybe because he was replying to the cover letter).

As Aurelien mentioned, the current shutdown/reboot (and possibly the regulator
as well) intends to use the `default MFD_SPACEMIT_P1`.
So if there’s no `default m if ARCH_SPACEMIT`,
the default value in subdevices may not make much sense.

But don’t worry — to make things easier for you, I’ll send an additional
patch based on your branch (in this series).

How does that sound?

Link: https://lore.kernel.org/all/aP9IVckJT-k2_O4K@aurel32.net/ [1]
> 
> --
> Lee Jones [李琼斯]
> 
>