linux-kernel - Re: [PATCH v2 0/3] Cleanups in amd64_edac and removal of legacy EDAC sysfs interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251107124025.GRaQ3ouSiYdtQemqI3@fat_crate.local>
Date: Fri, 7 Nov 2025 13:40:25 +0100
From: Borislav Petkov <bp@...en8.de>
To: Avadhut Naik <avadhut.naik@....com>
Cc: linux-edac@...r.kernel.org, linux-doc@...r.kernel.org,
	gregkh@...uxfoundation.org, corbet@....net, chenhuacai@...nel.org,
	mchehab+huawei@...nel.org, yazen.ghannam@....com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/3] Cleanups in amd64_edac and removal of legacy EDAC
 sysfs interface

On Thu, Nov 06, 2025 at 01:54:43AM +0000, Avadhut Naik wrote:
> This patchset undertakes some cleanups in the amd64_edac module and
> removes the legacy EDAC sysfs interface since it has been obsolete for
> more than a decade.
> 
> The first patch removes explicit assignment of the ctl_name string and
> instead generates it at runtime using scnprintf.
> 
> The second patch removes the NUM_CONTROLLERS macro and instead uses the
> max_mcs variable to determine the size of chipselect array.
> 
> The third patch removes the old EDAC sysfs interface.
> 
> NOTE:
> These cleanups were earlier submitted as part of the set adding EDAC
> support for AMD's newer Family 1Ah-based SOCs.[1] However, since the
> support patches were critical to enabling EDAC on newer AMD SOCs and
> since these cleanups were still under review, the set was split up.
> 
> [1]: https://lore.kernel.org/all/20250909185748.1621098-1-avadhut.naik@amd.com/
> 
> Changes in v2:
>  - Drop the patch that set zn_regs_v2 flag for all SOCs based on Family
> 1Ah and later.
>  - Change MAX_CTL_NAMELEN macro from 20 to 19.
>  - Modify commit message of the second patch per feedback received.
>  - Skip deprecation and just remove the old EDAC sysfs interface.
> 
> Links:
> v1: https://lore.kernel.org/all/20251013173632.1449366-1-avadhut.naik@amd.com/
> 
> Avadhut Naik (3):
>   EDAC/amd64: Generate ctl_name string at runtime
>   EDAC/amd64: Remove NUM_CONTROLLERS macro
>   edac: Remove the legacy EDAC sysfs interface
> 
>  Documentation/admin-guide/RAS/main.rst     | 142 +-------
>  arch/loongarch/configs/loongson3_defconfig |   1 -
>  drivers/edac/Kconfig                       |   8 -
>  drivers/edac/amd64_edac.c                  |  61 +---
>  drivers/edac/amd64_edac.h                  |   7 +-
>  drivers/edac/edac_mc_sysfs.c               | 404 ---------------------
>  6 files changed, 22 insertions(+), 601 deletions(-)

Queued, thanks.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette