linux-kernel - Re: [PATCH net v2] net: dsa: b53: bcm531x5: fix cpu rgmii mode interpretation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ce95eb8c-0d40-464d-b729-80e1ea71051c@lunn.ch>
Date: Fri, 7 Nov 2025 14:20:24 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Jonas Gorski <jonas.gorski@...il.com>
Cc: Florian Fainelli <florian.fainelli@...adcom.com>,
	Vladimir Oltean <olteanv@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Álvaro Fernández Rojas <noltari@...il.com>
Subject: Re: [PATCH net v2] net: dsa: b53: bcm531x5: fix cpu rgmii mode
 interpretation

> +	/* Older driver versions incorrectly applied delays in
> +	 * PHY_INTERFACE_MODE_RGMII mode. In order to not break old users, keep
> +	 * interpreting RGMII as RGMII-ID.
> +	 */
> +	if (interface == PHY_INTERFACE_MODE_RGMII)
> +		interface = PHY_INTERFACE_MODE_RGMII_ID;

Did you look through the in kernel .dts files? How many systems does
this effect?

I would maybe add a dev_warn() here, saying the DT blob is out of date
and needs fixing. And fix all the in kernel .dts files.

	Andrew