linux-kernel - Re: [PATCH net v2] net: dsa: b53: bcm531x5: fix cpu rgmii mode interpretation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ec456ae4-18ea-4f77-ba9a-a5d35bf1b1fd@lunn.ch>
Date: Fri, 7 Nov 2025 15:07:48 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Jonas Gorski <jonas.gorski@...il.com>
Cc: Florian Fainelli <florian.fainelli@...adcom.com>,
	Vladimir Oltean <olteanv@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Álvaro Fernández Rojas <noltari@...il.com>
Subject: Re: [PATCH net v2] net: dsa: b53: bcm531x5: fix cpu rgmii mode
 interpretation

> There is allwinner/sun7i-a20-lamobo-r1.dts, which uses "rgmii-txid",
> which is untouched by this patch. The ethernet interface uses "rgmii".

Which is odd, but lets leave it alone.

> And there is arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-elbert.dts,
> where a comment says that it has a BCM53134, but there is no such
> node. The ethernet node uses "rgmii".

aspeed pretty much always get phy-mode wrong. So i would not worry too
much about this.

> So one doesn't define one, one uses rgmii-id on the switch / phy side
> and rgmii on the ethernet mac side, and one only defines the ethernet
> mac side as rgmii.

That is reasonable. It is a lot less clear what is correct for a
MAC-MAC connection. For a MAC-PHY connection we do have documentation,
the preference is that the PHY adds the delays, not the MAC. If the
switch is playing PHY, then having it add delays is sensible.

> > I would maybe add a dev_warn() here, saying the DT blob is out of date
> > and needs fixing. And fix all the in kernel .dts files.
> 
> Sure I can add a warning.

Great, thanks.

	Andrew