linux-kernel - Re: [PATCH] gpu: nova-core: apply the one "use" item per line policy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DE2IZB6X5QQN.NZHOR450WZSZ@nvidia.com>
Date: Fri, 07 Nov 2025 23:17:15 +0900
From: "Alexandre Courbot" <acourbot@...dia.com>
To: "Danilo Krummrich" <dakr@...nel.org>, "John Hubbard"
 <jhubbard@...dia.com>
Cc: "Alexandre Courbot" <acourbot@...dia.com>, "Joel Fernandes"
 <joelagnelf@...dia.com>, "Timur Tabi" <ttabi@...dia.com>, "Alistair Popple"
 <apopple@...dia.com>, "Edwin Peer" <epeer@...dia.com>, "Zhi Wang"
 <zhiw@...dia.com>, "David Airlie" <airlied@...il.com>, "Simona Vetter"
 <simona@...ll.ch>, "Bjorn Helgaas" <bhelgaas@...gle.com>, "Miguel Ojeda"
 <ojeda@...nel.org>, "Alex Gaynor" <alex.gaynor@...il.com>, "Boqun Feng"
 <boqun.feng@...il.com>, "Gary Guo" <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>, "Benno Lossin"
 <lossin@...nel.org>, "Andreas Hindborg" <a.hindborg@...nel.org>, "Alice
 Ryhl" <aliceryhl@...gle.com>, "Trevor Gross" <tmgross@...ch.edu>,
 <nouveau@...ts.freedesktop.org>, <rust-for-linux@...r.kernel.org>, "LKML"
 <linux-kernel@...r.kernel.org>, "Nouveau"
 <nouveau-bounces@...ts.freedesktop.org>
Subject: Re: [PATCH] gpu: nova-core: apply the one "use" item per line
 policy

On Fri Nov 7, 2025 at 6:42 PM JST, Danilo Krummrich wrote:
> On Fri Nov 7, 2025 at 3:10 AM CET, John Hubbard wrote:
>> As per [1], we need one "use" item per line, in order to reduce merge
>> conflicts. Furthermore, we need a trailing ", //" in order to tell
>> rustfmt(1) to leave it alone.
>>
>> This does that for the entire nova-core driver.
>>
>> [1] https://docs.kernel.org/rust/coding-guidelines.html#imports
>>
>> Signed-off-by: John Hubbard <jhubbard@...dia.com>
>
> Thanks for doing this!
>
> Few nits below, I assume Alex will fix them up on apply, so no need to resend.
>
> With those fixed,
>
> Acked-by: Danilo Krummrich <dakr@...nel.org>

Applied these suggestions, thanks!

I've also noticed that sometimes the trailing `//` on the final line are
not always necessary if some intermediate sub-blocks already had one,
I've also removed such cases that do not affect rustfmt.

Planning on pushing tomorrow.