linux-kernel - Re: [PATCH] drm/sched: Don't crash kernel on wrong params

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADnq5_OU_bxHctMD5KjMfzsW4gaq8kC7fsO8TdgJr9kzLOCh5A@mail.gmail.com>
Date: Fri, 7 Nov 2025 09:27:52 -0500
From: Alex Deucher <alexdeucher@...il.com>
To: Philipp Stanner <phasta@...nel.org>
Cc: Matthew Brost <matthew.brost@...el.com>, Danilo Krummrich <dakr@...nel.org>, 
	Christian König <ckoenig.leichtzumerken@...il.com>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/sched: Don't crash kernel on wrong params

On Fri, Nov 7, 2025 at 8:01 AM Philipp Stanner <phasta@...nel.org> wrote:
>
> drm_sched_job_arm() just panics the kernel with BUG_ON() in case of an
> entity being NULL. While drm_sched_job_arm() crashing or not effectively
> arming jobs is certainly a huge issue that needs to be noticed,
> completely shooting down the kernel reduces the probability of reaching
> and debugging a system to 0.
>
> Moreover, the checkpatch script by now strongly discourages all new uses
> of BUG_ON() for this reason.
>
> Replace the BUG_ON() in drm_sched_job_arm() with a WARN_ON().
>
> Signed-off-by: Philipp Stanner <phasta@...nel.org>

Acked-by: Alex Deucher <alexander.deucher@....com>

> ---
>  drivers/gpu/drm/scheduler/sched_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
> index 1d4f1b822e7b..3bf4ae0ca4bc 100644
> --- a/drivers/gpu/drm/scheduler/sched_main.c
> +++ b/drivers/gpu/drm/scheduler/sched_main.c
> @@ -857,7 +857,7 @@ void drm_sched_job_arm(struct drm_sched_job *job)
>         struct drm_gpu_scheduler *sched;
>         struct drm_sched_entity *entity = job->entity;
>
> -       BUG_ON(!entity);
> +       WARN_ON(!entity);
>         drm_sched_entity_select_rq(entity);
>         sched = entity->rq->sched;
>
> --
> 2.49.0
>