linux-kernel - RE: [PATCH v21 3/4] i2c: ast2600: Add controller driver for new register layout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <TY2PPF5CB9A1BE6B128FE8388B5152B5752F2C0A@TY2PPF5CB9A1BE6.apcprd06.prod.outlook.com>
Date: Sat, 8 Nov 2025 03:47:31 +0000
From: Ryan Chen <ryan_chen@...eedtech.com>
To: "andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>
CC: Krzysztof Kozlowski <krzk@...nel.org>, BMC-SW <BMC-SW@...eedtech.com>,
	"benh@...nel.crashing.org" <benh@...nel.crashing.org>, "joel@....id.au"
	<joel@....id.au>, "andi.shyti@...nel.org" <andi.shyti@...nel.org>,
	"jk@...econstruct.com.au" <jk@...econstruct.com.au>, "robh@...nel.org"
	<robh@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "andrew@...econstruct.com.au"
	<andrew@...econstruct.com.au>, "p.zabel@...gutronix.de"
	<p.zabel@...gutronix.de>, "naresh.solanki@...ements.com"
	<naresh.solanki@...ements.com>, "linux-i2c@...r.kernel.org"
	<linux-i2c@...r.kernel.org>, "openbmc@...ts.ozlabs.org"
	<openbmc@...ts.ozlabs.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v21 3/4] i2c: ast2600: Add controller driver for new
 register layout

> Subject: Re: [PATCH v21 3/4] i2c: ast2600: Add controller driver for new
> register layout
> 
> On Fri, Nov 07, 2025 at 06:26:39AM +0000, Ryan Chen wrote:
> > > On 27/10/2025 07:12, Ryan Chen wrote:
> 
> ...
> 
> > Add new file i2c-aspeed-core.c to do legacy probe and i2c-ast2600 probe.
> >
> > 	if (of_device_is_compatible(dev_of_node(dev), "aspeed,ast2600-i2c-bus")
> &&
> 
> 	if (device_is_compatible(dev, "aspeed,ast2600-i2c-bus") &&
> 
> > 	    of_parse_phandle(dev_of_node(dev), "aspeed,global-regs", 0)) {
> 
> Not sure why do you need this. Isn't it as simple as
> 
> 	    device_property_present(dev, "aspeed,global-regs", 0)) {
> 
> or something between these lines?

Thanks Andy.

I will update logic as:
if (device_is_compatible(dev, "aspeed,ast2600-i2c-bus") &&
    device_property_present(dev, "aspeed,global-regs"))
	ret = ast2600_i2c_probe(pdev);
else
	ret = aspeed_i2c_probe(pdev);

> 
> > 		ret = ast2600_i2c_probe(pdev);
> > 	} else {
> > 		ret = aspeed_i2c_probe(pdev);
> > 	}
> 
> --
> With Best Regards,
> Andy Shevchenko
>