linux-kernel - Re: [PATCH 2/2] fpga: stratix10-soc: add COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aQ7As9KVG+5Dn5FB@yilunxu-OptiPlex-7050>
Date: Sat, 8 Nov 2025 12:01:55 +0800
From: Xu Yilun <yilun.xu@...ux.intel.com>
To: Rosen Penev <rosenp@...il.com>
Cc: linux-fpga@...r.kernel.org, Moritz Fischer <mdf@...nel.org>,
	Xu Yilun <yilun.xu@...el.com>, Tom Rix <trix@...hat.com>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] fpga: stratix10-soc: add COMPILE_TEST support

On Fri, Nov 07, 2025 at 11:28:03AM -0800, Rosen Penev wrote:
> On Thu, Nov 6, 2025 at 11:30 PM Xu Yilun <yilun.xu@...ux.intel.com> wrote:
> >
> > On Thu, Nov 06, 2025 at 10:59:38AM -0800, Rosen Penev wrote:
> > > Allow the buildbots to find compilation issues.
> > >
> > > Signed-off-by: Rosen Penev <rosenp@...il.com>
> > > ---
> > >  drivers/fpga/Kconfig | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> > > index 311313f3b282..f2e2776acdd5 100644
> > > --- a/drivers/fpga/Kconfig
> > > +++ b/drivers/fpga/Kconfig
> > > @@ -60,7 +60,7 @@ config FPGA_MGR_ZYNQ_FPGA
> > >
> > >  config FPGA_MGR_STRATIX10_SOC
> > >       tristate "Intel Stratix10 SoC FPGA Manager"
> > > -     depends on (ARCH_INTEL_SOCFPGA && INTEL_STRATIX10_SERVICE)
> > > +     depends on (ARCH_INTEL_SOCFPGA && INTEL_STRATIX10_SERVICE) || COMPILE_TEST
> >
> > I don't think it works without INTEL_STRATIX10_SERVICE, maybe:
> >
> >         depends on ARCH_INTEL_SOCFPGA || COMPILE_TEST
> >         depends on INTEL_STRATIX10_SERVICE
> >
> > But INTEL_STRATIX10_SERVICE depends on HAVE_ARM_SMCCC, and they all
> > require arch configurations...
> Yeah I don't think INTEL_STRATIX10_SERVICE is needed for COMPILE_TEST.

Have you actually passed compilation without INTEL_STRATIX10_SERVICE?
I can't image how it works without stratix10_svc_xx kAPI definitions.

> >
> > >       help
> > >         FPGA manager driver support for the Intel Stratix10 SoC.
> > >
> > > --
> > > 2.51.2
> > >
> > >