linux-kernel - Re: [PATCH] iommupt: Actually correct pt_test_sw_bit_{acquire

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a304ad66-6ab5-44ba-8454-23cd01f7854f@infradead.org>
Date: Fri, 7 Nov 2025 16:19:49 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: Bagas Sanjaya <bagasdotme@...il.com>,
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
 Linux IOMMU <iommu@...ts.linux.dev>
Cc: Joerg Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>,
 Robin Murphy <robin.murphy@....com>, Jason Gunthorpe <jgg@...pe.ca>,
 Kevin Tian <kevin.tian@...el.com>, Lu Baolu <baolu.lu@...ux.intel.com>
Subject: Re: [PATCH] iommupt: Actually correct
 pt_test_sw_bit_{acquire_release}() parameter description



On 11/7/25 3:33 PM, Bagas Sanjaya wrote:
> In review comment for v1 of genpt documentation fixes [1], Randy
> suggested that pt_test_sw_bit_acquire() parameters description
> should be written using "to read". Commit e4dfaf25df1210 ("iommupt:
> Describe @bitnr parameter"), however, misunderstood the review by
> instead using "to read" on @bitnr parameter on both
> pt_test_sw_bit_acquire() and pt_test_sw_bit_release().
> 
> Actually correct the description.
> 
> [1]: https://lore.kernel.org/linux-doc/9dba0eb7-6f32-41b7-b70b-12379364585f@infradead.org/
> 
> Fixes: e4dfaf25df1210 ("iommupt: Describe @bitnr parameter")
> Signed-off-by: Bagas Sanjaya <bagasdotme@...il.com>

Looks good. Thanks.

Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

> ---
>  drivers/iommu/generic_pt/pt_common.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iommu/generic_pt/pt_common.h b/drivers/iommu/generic_pt/pt_common.h
> index 3b4e371089140a..e1123d35c90765 100644
> --- a/drivers/iommu/generic_pt/pt_common.h
> +++ b/drivers/iommu/generic_pt/pt_common.h
> @@ -353,7 +353,7 @@ static inline unsigned int pt_max_sw_bit(struct pt_common *common);
>  
>  /**
>   * pt_test_sw_bit_acquire() - Read a software bit in an item
> - * @pts: Entry to set
> + * @pts: Entry to read
>   * @bitnr: Bit to read
>   *
>   * Software bits are ignored by HW and can be used for any purpose by the
> @@ -365,7 +365,7 @@ static inline bool pt_test_sw_bit_acquire(struct pt_state *pts,
>  /**
>   * pt_set_sw_bit_release() - Set a software bit in an item
>   * @pts: Entry to set
> - * @bitnr: Bit to read
> + * @bitnr: Bit to set
>   *
>   * Software bits are ignored by HW and can be used for any purpose by the
>   * software. This does a set bit and release operation.
> 
> base-commit: 91920a9d87f5192c56ba5bf3e133aeb3576b705d

-- 
~Randy