linux-kernel - Re: [PATCH v6 3/4] gpu: nova-core: make Architecture behave as a u8 type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5342a0f10a3e9ef7d3165bd8912bd042ae7f68f5.camel@nvidia.com>
Date: Sat, 8 Nov 2025 05:03:53 +0000
From: Timur Tabi <ttabi@...dia.com>
To: "dakr@...nel.org" <dakr@...nel.org>, John Hubbard <jhubbard@...dia.com>
CC: Alexandre Courbot <acourbot@...dia.com>, "lossin@...nel.org"
	<lossin@...nel.org>, "a.hindborg@...nel.org" <a.hindborg@...nel.org>,
	"boqun.feng@...il.com" <boqun.feng@...il.com>, "aliceryhl@...gle.com"
	<aliceryhl@...gle.com>, Zhi Wang <zhiw@...dia.com>, "simona@...ll.ch"
	<simona@...ll.ch>, "alex.gaynor@...il.com" <alex.gaynor@...il.com>,
	"ojeda@...nel.org" <ojeda@...nel.org>, "tmgross@...ch.edu"
	<tmgross@...ch.edu>, "nouveau@...ts.freedesktop.org"
	<nouveau@...ts.freedesktop.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "rust-for-linux@...r.kernel.org"
	<rust-for-linux@...r.kernel.org>, "bjorn3_gh@...tonmail.com"
	<bjorn3_gh@...tonmail.com>, Edwin Peer <epeer@...dia.com>,
	"airlied@...il.com" <airlied@...il.com>, Joel Fernandes
	<joelagnelf@...dia.com>, "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
	"gary@...yguo.net" <gary@...yguo.net>, Alistair Popple <apopple@...dia.com>
Subject: Re: [PATCH v6 3/4] gpu: nova-core: make Architecture behave as a u8
 type

On Fri, 2025-11-07 at 20:39 -0800, John Hubbard wrote:
>  /// Enum representation of the GPU generation.
> -#[derive(fmt::Debug)]
> +#[derive(fmt::Debug, Default, Copy, Clone)]
> +#[repr(u8)]
>  pub(crate) enum Architecture {
> +    #[default]
>      Turing = 0x16,
>      Ampere = 0x17,
>      Ada = 0x19,
> @@ -142,6 +144,13 @@ fn try_from(value: u8) -> Result<Self> {
>      }
>  }

Does it make sense to designate a default Architecture?  Turing is not a fallback for Ampere --
you can't boot an Ampere with Turing's HAL.  Also, we don't even make Turing cards any more, so
over time, Turing will be less and less common.