linux-kernel - [PATCH] bus: arm-cci: Fix device node reference leak in cci_probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20251108063219.550810-1-karanja99erick@gmail.com>
Date: Sat,  8 Nov 2025 09:32:19 +0300
From: Erick Karanja <karanja99erick@...il.com>
To: Manivannan Sadhasivam <mani@...nel.org>
Cc: Jeff Hugo <jeff.hugo@....qualcomm.com>,
	Christophe Leroy <christophe.leroy@...roup.eu>,
	Ioana Ciornei <ioana.ciornei@....com>,
	Vivek Pernamitta <quic_vpernami@...cinc.com>,
	linux-kernel@...r.kernel.org,
	linux-kernel-mentees@...ts.linux.dev,
	Erick Karanja <karanja99erick@...il.com>
Subject: [PATCH] bus: arm-cci: Fix device node reference leak in cci_probe_ports()

Although the reference to the  child node cp is
assigned later in the iteration, when an early break
occurs, the reference to child node needs to be
released.

Fixes: ed69bdd8fd9b2 ("drivers: bus: add ARM CCI support")
Signed-off-by: Erick Karanja <karanja99erick@...il.com>
---
 drivers/bus/arm-cci.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
index b8184a903583..1f84a5528073 100644
--- a/drivers/bus/arm-cci.c
+++ b/drivers/bus/arm-cci.c
@@ -461,8 +461,10 @@ static int cci_probe_ports(struct device_node *np)
 
 		i = nb_ace + nb_ace_lite;
 
-		if (i >= nb_cci_ports)
+		if (i >= nb_cci_ports) {
+			of_node_put(cp);
 			break;
+		}
 
 		if (of_property_read_string(cp, "interface-type",
 					&match_str)) {
-- 
2.43.0