linux-kernel - Re: [PATCH 0/3] riscv: soc: re-organized allwinner

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4692596.LvFx2qVVIh@jernej-laptop>
Date: Sat, 08 Nov 2025 10:46:41 +0100
From: Jernej Škrabec <jernej.skrabec@...il.com>
To: Paul Walmsley <pjw@...nel.org>, Palmer Dabbelt <palmer@...belt.com>,
 Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
 Samuel Holland <samuel@...lland.org>, Han Gao <gaohan@...as.ac.cn>,
 Yixun Lan <dlan@...too.org>, Drew Fustini <fustini@...nel.org>,
 Geert Uytterhoeven <geert+renesas@...der.be>,
 Guodong Xu <guodong@...cstar.com>, Haylen Chu <heylenay@....org>,
 Joel Stanley <joel@....id.au>, gaohan@...as.ac.cn
Cc: linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-sunxi@...ts.linux.dev, Han Gao <rabenda.cn@...il.com>
Subject: Re: [PATCH 0/3] riscv: soc: re-organized allwinner

Hi,

Dne sobota, 8. november 2025 ob 09:20:22 Srednjeevropski standardni čas je gaohan@...as.ac.cn napisal(a):
> From: Han Gao <gaohan@...as.ac.cn>
> 
> Allwinner currently offers d1(s)/v821/v861/v881 on RISC-V,
> using different IPs.
> 
> d1(s): Xuantie C906
> v821: Andes A27 + XuanTie E907
> v861/v881: XuanTie C907
> 
> Han Gao (3):
>   riscv: soc: re-organized allwinner menu
>   riscv: soc: allwinner: d1: use the ARCH_SUNXI_XUANTIE
>   riscv: defconfig: enable SUNXI_XUANTIE and SUNXI_ANDES

This series is incomplete. It introduces ARCH_SUNXI_ANDES symbol but it is
never used.

Additionally, patches are not organized properly. First, you should introduce
reorganization and only then introduce new features. Also, not a single
patch should break existing functionality for bisectability reasons. First
patch breaks compilation of DT files while second restores that. This must
not happen.

Best regards,
Jernej

> 
>  arch/riscv/Kconfig.socs                | 22 +++++++++++++++++-----
>  arch/riscv/boot/dts/allwinner/Makefile | 20 ++++++++++----------
>  arch/riscv/configs/defconfig           |  2 ++
>  3 files changed, 29 insertions(+), 15 deletions(-)
> 
>