lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAAhV-H58u2xXYG0X3giazizpuBqT-0qdGojbBsmwD2U1Z7D_vQ@mail.gmail.com>
Date: Sat, 8 Nov 2025 19:54:38 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: "Vishal Moola (Oracle)" <vishal.moola@...il.com>
Cc: linux-kernel@...r.kernel.org, loongarch@...ts.linux.dev
Subject: Re: [PATCH] LoongArch: Remove __GFP_HIGHMEM masking

Hi, Vishal,

On Sat, Nov 8, 2025 at 2:06 AM Vishal Moola (Oracle)
<vishal.moola@...il.com> wrote:
>
> Remove unnecessary __GFP_HIGHMEM masking, which was introduced with
> commit 382739797f79 ("loongarch: convert various functions to use
> ptdescs"). GFP_KERNEL doesn't contain __GFP_HIGHMEM.
I have planned to submit a similar patch after [1] is merged, but
anyway, thank you for your contribution.

[1] https://lore.kernel.org/linux-mm/CAAhV-H5C_Af72a5QcJs25qUMsJqO26=8oNvvLrJ7z+xHZh8oKQ@mail.gmail.com/T/#t

Huacai

>
> Signed-off-by: Vishal Moola (Oracle) <vishal.moola@...il.com>
> ---
>  arch/loongarch/include/asm/pgalloc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/loongarch/include/asm/pgalloc.h b/arch/loongarch/include/asm/pgalloc.h
> index 1c63a9d9a6d3..08dcc698ec18 100644
> --- a/arch/loongarch/include/asm/pgalloc.h
> +++ b/arch/loongarch/include/asm/pgalloc.h
> @@ -88,7 +88,7 @@ static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, unsigned long address)
>  static inline pud_t *pud_alloc_one(struct mm_struct *mm, unsigned long address)
>  {
>         pud_t *pud;
> -       struct ptdesc *ptdesc = pagetable_alloc(GFP_KERNEL & ~__GFP_HIGHMEM, 0);
> +       struct ptdesc *ptdesc = pagetable_alloc(GFP_KERNEL, 0);
>
>         if (!ptdesc)
>                 return NULL;
> --
> 2.51.1
>
>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ