linux-kernel - Re: [PATCH v2] ksmbd: clear 'encrypted' on encrypt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKYAXd9q2fHmjNAydw_F=JNW_CzM-7XuUpc9_0iqt-0HsGOq6g@mail.gmail.com>
Date: Sat, 8 Nov 2025 23:27:05 +0900
From: Namjae Jeon <linkinjeon@...nel.org>
To: Qianchang Zhao <pioooooooooip@...il.com>
Cc: linux-cifs@...r.kernel.org, Steve French <smfrench@...il.com>, 
	Sergey Senozhatsky <senozhatsky@...omium.org>, Tom Talpey <tom@...pey.com>, linux-kernel@...r.kernel.org, 
	stable@...r.kernel.org, gregkh@...uxfoundation.org, 
	Zhitong Liu <liuzhitong1993@...il.com>
Subject: Re: [PATCH v2] ksmbd: clear 'encrypted' on encrypt_resp() failure to
 send plaintext error

On Thu, Nov 6, 2025 at 3:58 PM Qianchang Zhao <pioooooooooip@...il.com> wrote:
>
> When encrypt_resp() fails in the send path, we set STATUS_DATA_ERROR but
> leave work->encrypted true. The send path then still assumes a valid
> transform buffer and tries to build/send an encrypted reply.
>
> Clear work->encrypted on failure to force a plaintext error reply.
ksmbd will send a plain text error reply regardless of the
work->encrypted value.
It doesn't seem to make any sense to set this to false.
Thanks.