linux-kernel - Re: [PATCH Resend] mm: Refine __{pgd,p4d,pud,pmd,pte}_alloc_one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20251108084724.3e389b6597294900347b0476@linux-foundation.org>
Date: Sat, 8 Nov 2025 08:47:24 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Huacai Chen <chenhuacai@...nel.org>
Cc: "Vishal Moola (Oracle)" <vishal.moola@...il.com>, Huacai Chen
 <chenhuacai@...ngson.cn>, Arnd Bergmann <arnd@...db.de>, Kevin Brodsky
 <kevin.brodsky@....com>, Jan Kara <jack@...e.cz>, linux-mm@...ck.org,
 linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH Resend] mm: Refine __{pgd,p4d,pud,pmd,pte}_alloc_one_*()
 about HIGHMEM

On Sat, 8 Nov 2025 16:34:20 +0800 Huacai Chen <chenhuacai@...nel.org> wrote:

> Hi, Vishal,
> 
> On Sat, Nov 8, 2025 at 12:59 AM Vishal Moola (Oracle)
> <vishal.moola@...il.com> wrote:
> >
> > On Fri, Nov 07, 2025 at 05:59:22PM +0800, Huacai Chen wrote:
> > > __{pgd,p4d,pud,pmd,pte}_alloc_one_*() always allocate pages with GFP
> > > flag GFP_PGTABLE_KERNEL/GFP_PGTABLE_USER. These two macros are defined
> > > as follows:
> > >
> > >  #define GFP_PGTABLE_KERNEL   (GFP_KERNEL | __GFP_ZERO)
> > >  #define GFP_PGTABLE_USER     (GFP_PGTABLE_KERNEL | __GFP_ACCOUNT)
> > >
> > > There is no __GFP_HIGHMEM in them, so we needn't to clear __GFP_HIGHMEM
> > > explicitly.
> > >
> > > Signed-off-by: Huacai Chen <chenhuacai@...ngson.cn>
> > > ---
> >
> > I'm not really sure what "Refine ... about HIGHMEM" is supposed to mean.
> > Might it be clearer to title this something like "Remove unnecessary
> > highmem in ..."?
> Yes, that is better, but Andrew has picked this patch, should I resend
> a new version?

Please just send along a v2 in the usual fashion.