linux-kernel - Re: [PATCH] scsi: mpt3sas: use sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1cy5sif94.fsf@ca-mkp.ca.oracle.com>
Date: Sat, 08 Nov 2025 12:53:52 -0500
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Shi Hao <i.shihao.999@...il.com>
Cc: sathya.prakash@...adcom.com, sreekanth.reddy@...adcom.com,
        suganath-prabu.subramani@...adcom.com,
        James.Bottomley@...senPartnership.com, martin.petersen@...cle.com,
        MPT-FusionLinux.pdl@...adcom.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: mpt3sas: use sysfs_emit function in sysfs


Shi,

> Replace snprintf() with sysfs_emit() function as it removes
> unnecessary use cases of PAGE_SIZE also it is much preferred for sysfs
> functions. This conversion makes code more maintainable and follows
> current kernel code guidelines.

>From Documentation/filesystems/sysfs.rst:

 - New implementations of show() methods should only use sysfs_emit() or
   sysfs_emit_at() when formatting the value to be returned to user space.

mpt3sas is not a "new implementation".

-- 
Martin K. Petersen