Message-Id: <20251108100104.bb9fc75f97b9263af7e5673b@linux-foundation.org>
Date: Sat, 8 Nov 2025 10:01:04 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
Cc: Christian Borntraeger <borntraeger@...ux.ibm.com>, Janosch Frank
 <frankja@...ux.ibm.com>, Claudio Imbrenda <imbrenda@...ux.ibm.com>, David
 Hildenbrand <david@...hat.com>, Alexander Gordeev <agordeev@...ux.ibm.com>,
 Gerald Schaefer <gerald.schaefer@...ux.ibm.com>, Heiko Carstens
 <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>, Sven Schnelle
 <svens@...ux.ibm.com>, Peter Xu <peterx@...hat.com>, Alexander Viro
 <viro@...iv.linux.org.uk>, Christian Brauner <brauner@...nel.org>, Jan Kara
 <jack@...e.cz>, Arnd Bergmann <arnd@...db.de>, Zi Yan <ziy@...dia.com>,
 Baolin Wang <baolin.wang@...ux.alibaba.com>, "Liam R . Howlett"
 <Liam.Howlett@...cle.com>, Nico Pache <npache@...hat.com>, Ryan Roberts
 <ryan.roberts@....com>, Dev Jain <dev.jain@....com>, Barry Song
 <baohua@...nel.org>, Lance Yang <lance.yang@...ux.dev>, Muchun Song
 <muchun.song@...ux.dev>, Oscar Salvador <osalvador@...e.de>, Vlastimil
 Babka <vbabka@...e.cz>, Mike Rapoport <rppt@...nel.org>, Suren Baghdasaryan
 <surenb@...gle.com>, Michal Hocko <mhocko@...e.com>, Matthew Brost
 <matthew.brost@...el.com>, Joshua Hahn <joshua.hahnjy@...il.com>, Rakie Kim
 <rakie.kim@...com>, Byungchul Park <byungchul@...com>, Gregory Price
 <gourry@...rry.net>, Ying Huang <ying.huang@...ux.alibaba.com>, Alistair
 Popple <apopple@...dia.com>, Axel Rasmussen <axelrasmussen@...gle.com>,
 Yuanchu Xie <yuanchu@...gle.com>, Wei Xu <weixugc@...gle.com>, Kemeng Shi
 <shikemeng@...weicloud.com>, Kairui Song <kasong@...cent.com>, Nhat Pham
 <nphamcs@...il.com>, Baoquan He <bhe@...hat.com>, Chris Li
 <chrisl@...nel.org>, SeongJae Park <sj@...nel.org>, Matthew Wilcox
 <willy@...radead.org>, Jason Gunthorpe <jgg@...pe.ca>, Leon Romanovsky
 <leon@...nel.org>, Xu Xin <xu.xin16@....com.cn>, Chengming Zhou
 <chengming.zhou@...ux.dev>, Jann Horn <jannh@...gle.com>, Miaohe Lin
 <linmiaohe@...wei.com>, Naoya Horiguchi <nao.horiguchi@...il.com>, Pedro
 Falcato <pfalcato@...e.de>, Pasha Tatashin <pasha.tatashin@...een.com>, Rik
 van Riel <riel@...riel.com>, Harry Yoo <harry.yoo@...cle.com>, Hugh Dickins
 <hughd@...gle.com>, linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
 linux-s390@...r.kernel.org, linux-fsdevel@...r.kernel.org,
 linux-mm@...ck.org, linux-arch@...r.kernel.org, damon@...ts.linux.dev
Subject: Re: [PATCH v2 00/16] mm: remove is_swap_[pte, pmd]() + non-swap
 entries, introduce leaf entries

On Sat,  8 Nov 2025 17:08:14 +0000 Lorenzo Stoakes <lorenzo.stoakes@...cle.com> wrote:

> There's an established convention in the kernel that we treat leaf page
> tables (so far at the PTE, PMD level) as containing 'swap entries' should
> they be neither empty (i.e. p**_none() evaluating true) nor present
> (i.e. p**_present() evaluating true).
> 
> However, at the same time we also have helper predicates - is_swap_pte(),
> is_swap_pmd() - which are inconsistently used.
> 
> This is problematic, as it is logical to assume that should somebody wish
> to operate upon a page table swap entry they should first check to see if
> it is in fact one.
> 
> It also implies that perhaps, in future, we might introduce a non-present,
> none page table entry that is not a swap entry.
> 
> This series resolves this issue by systematically eliminating all use of
> the is_swap_pte() and is swap_pmd() predicates so we retain only the
> convention that should a leaf page table entry be neither none nor present
> it is a swap entry.

Thanks, I've updated mm.git's mm-unstable branch to this v2 series.

Powered by blists - more mailing lists