linux-kernel - [PATCH v5.10.y] fsdax: mark the iomap argument to dax_iomap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20251109113151.48263-1-farbere@amazon.com>
Date: Sun, 9 Nov 2025 11:31:51 +0000
From: Eliav Farber <farbere@...zon.com>
To: <gregkh@...uxfoundation.org>, <stable-commits@...r.kernel.org>,
	<viro@...iv.linux.org.uk>, <dan.j.williams@...el.com>, <willy@...radead.org>,
	<jack@...e.cz>, <linux-fsdevel@...r.kernel.org>, <linux-nvdimm@...ts.01.org>,
	<linux-kernel@...r.kernel.org>
CC: <farbere@...zon.com>, Christoph Hellwig <hch@....de>, "Darrick J. Wong"
	<djwong@...nel.org>
Subject: [PATCH v5.10.y] fsdax: mark the iomap argument to dax_iomap_sector as const

From: Christoph Hellwig <hch@....de>

[ Upstream commit 7e4f4b2d689d959b03cb07dfbdb97b9696cb1076 ]

Signed-off-by: Christoph Hellwig <hch@....de>
Reviewed-by: Darrick J. Wong <djwong@...nel.org>
Signed-off-by: Darrick J. Wong <djwong@...nel.org>
---
Fixes:

fs/dax.c: In function 'dax_iomap_iter':
fs/dax.c:1147:44: error: passing argument 1 of 'dax_iomap_sector' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
   const sector_t sector = dax_iomap_sector(iomap, pos);
                                            ^~~~~
fs/dax.c:1009:17: note: expected 'struct iomap *' but argument is of type 'const struct iomap *'
   static sector_t dax_iomap_sector(struct iomap *iomap, loff_t pos)
                 ^~~~~~~~~~~~~~~~

The issue was introduced by the cherry-pick of commit 8df4919cb921
("fsdax: switch dax_iomap_rw to use iomap_iter")

https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/fs/dax.c?h=v5.10.246&id=8df4919cb921b28809d05feae3e98dc5d8b48146

The upstream change made callers pass a const struct iomap *:
   const struct iomap *iomap = &iomi->iomap;
but dax_iomap_sector() still expected a mutable pointer:
   static sector_t dax_iomap_sector(struct iomap *iomap, loff_t pos)

 fs/dax.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/dax.c b/fs/dax.c
index 91820b9b50b7..2ca33ef5d519 100644
--- a/fs/dax.c
+++ b/fs/dax.c
@@ -1006,7 +1006,7 @@ int dax_writeback_mapping_range(struct address_space *mapping,
 }
 EXPORT_SYMBOL_GPL(dax_writeback_mapping_range);
 
-static sector_t dax_iomap_sector(struct iomap *iomap, loff_t pos)
+static sector_t dax_iomap_sector(const struct iomap *iomap, loff_t pos)
 {
 	return (iomap->addr + (pos & PAGE_MASK) - iomap->offset) >> 9;
 }
-- 
2.47.3