linux-kernel - Re: [PATCH v6 05/26] iio: dac: ad3530r: #undef field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251109133513.195e6baa@jic23-huawei>
Date: Sun, 9 Nov 2025 13:35:13 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Geert Uytterhoeven <geert+renesas@...der.be>
Cc: Yury Norov <yury.norov@...il.com>, Michael Turquette
 <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, Nicolas Ferre
 <nicolas.ferre@...rochip.com>, Alexandre Belloni
 <alexandre.belloni@...tlin.com>, Claudiu Beznea <claudiu.beznea@...on.dev>,
 Giovanni Cabiddu <giovanni.cabiddu@...el.com>, Herbert Xu
 <herbert@...dor.apana.org.au>, David Miller <davem@...emloft.net>, Linus
 Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>,
 Joel Stanley <joel@....id.au>, Andrew Jeffery
 <andrew@...econstruct.com.au>, Crt Mori <cmo@...exis.com>, Lars-Peter
 Clausen <lars@...afoo.de>, Jacky Huang <ychuang3@...oton.com>, Shan-Chun
 Hung <schung@...oton.com>, Rasmus Villemoes <linux@...musvillemoes.dk>,
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, Johannes
 Berg <johannes@...solutions.net>, Jakub Kicinski <kuba@...nel.org>, Alex
 Elder <elder@...e.org>, David Laight <david.laight.linux@...il.com>,
 Vincent Mailhol <mailhol.vincent@...adoo.fr>, Jason Baron
 <jbaron@...mai.com>, Borislav Petkov <bp@...en8.de>, Tony Luck
 <tony.luck@...el.com>, Michael Hennerich <Michael.Hennerich@...log.com>,
 Kim Seer Paller <kimseer.paller@...log.com>, David Lechner
 <dlechner@...libre.com>, Nuno Sá <nuno.sa@...log.com>, Andy
 Shevchenko <andy@...nel.org>, Richard Genoud <richard.genoud@...tlin.com>,
 Cosmin Tanislav <demonsingur@...il.com>, Biju Das
 <biju.das.jz@...renesas.com>, Jianping Shen <Jianping.Shen@...bosch.com>,
 Nathan Chancellor <nathan@...nel.org>, Nick Desaulniers
 <nick.desaulniers+lkml@...il.com>, Miquel Raynal
 <miquel.raynal@...tlin.com>, Richard Weinberger <richard@....at>, Vignesh
 Raghavendra <vigneshr@...com>, linux-clk@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-renesas-soc@...r.kernel.org,
 linux-crypto@...r.kernel.org, linux-edac@...r.kernel.org,
 qat-linux@...el.com, linux-gpio@...r.kernel.org,
 linux-aspeed@...ts.ozlabs.org, linux-iio@...r.kernel.org,
 linux-sound@...r.kernel.org, linux-mtd@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 05/26] iio: dac: ad3530r: #undef field_prep() before
 local definition

On Thu,  6 Nov 2025 14:33:53 +0100
Geert Uytterhoeven <geert+renesas@...der.be> wrote:

> Prepare for the advent of a globally available common field_prep() macro
> by undefining the symbol before defining a local variant.  This prevents
> redefinition warnings from the C preprocessor when introducing the common
> macro later.
> 
> Suggested-by: Yury Norov <yury.norov@...il.com>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
Acked-by: Jonathan Cameron <jonathan.cameron@...wei.com>


> ---
> v6:
>   - No changes,
> 
> v5:
>   - New.
> ---
>  drivers/iio/dac/ad3530r.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/dac/ad3530r.c b/drivers/iio/dac/ad3530r.c
> index 6134613777b8e1d4..5684d11137f29948 100644
> --- a/drivers/iio/dac/ad3530r.c
> +++ b/drivers/iio/dac/ad3530r.c
> @@ -54,6 +54,7 @@
>  #define AD3531R_MAX_CHANNELS			4
>  
>  /* Non-constant mask variant of FIELD_PREP() */
> +#undef field_prep
>  #define field_prep(_mask, _val)	(((_val) << (ffs(_mask) - 1)) & (_mask))
>  
>  enum ad3530r_mode {