linux-kernel - Re: [PATCH v5] iio: imu: inv_icm45600: Initializes inv_icm45600_buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251109165617.330d1712@jic23-huawei>
Date: Sun, 9 Nov 2025 16:56:17 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Remi Buisson via B4 Relay <devnull+remi.buisson.tdk.com@...nel.org>
Cc: remi.buisson@....com, David Lechner <dlechner@...libre.com>, Nuno
 Sá <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org, Andy Shevchenko <andriy.shevchenko@...el.com>
Subject: Re: [PATCH v5] iio: imu: inv_icm45600: Initializes
 inv_icm45600_buffer_postdisable sleep

On Fri, 07 Nov 2025 13:49:56 +0000
Remi Buisson via B4 Relay <devnull+remi.buisson.tdk.com@...nel.org> wrote:

> From: Remi Buisson <remi.buisson@....com>
> 
> The sleep variable in inv_icm45600_buffer_postdisable() could be used without
> being assigned in case of error. It must be initialized to 0 by default.
> 
> Fixes: 06674a72cf7a ("iio: imu: inv_icm45600: add buffer support in iio devices")
> Closes: https://lore.kernel.org/linux-iio/aPi6Xw-ZoUkW76zR@stanley.mountain/
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...el.com>
> Signed-off-by: Remi Buisson <remi.buisson@....com>
Lots of versions.  Ah well. this is effectively the one b4 picked up.

J
> ---
> Changes in v5:
> - Adding parenthesis to function name in commit message
> - Adding Reviewed-by tag
> - Link to v4: https://lore.kernel.org/r/20251107-icm45600_fix_buffer_sleep_init-v4-1-5648fbfb57ad@tdk.com
> 
> Changes in v4:
> - Add space in closse tag in commit message
> - Remove extra blank line in commit message
> - Link to v3: https://lore.kernel.org/r/20251106-icm45600_fix_buffer_sleep_init-v3-1-ea3af68a3e61@tdk.com
> 
> Changes in v3:
> - Fix commit message: fix and closes moved to SoB
> - Fix assignement of sleep variable after declaration.
> - Link to v2: https://lore.kernel.org/r/20251031-icm45600_fix_buffer_sleep_init-v2-1-5cdc04e1bcba@tdk.com
> 
> Changes in v2:
> - Moving pacth description from cover-letter to single commit
> - Link to v1: https://lore.kernel.org/r/20251031-icm45600_fix_buffer_sleep_init-v1-1-924efbb165e8@tdk.com
> ---
>  drivers/iio/imu/inv_icm45600/inv_icm45600_buffer.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/imu/inv_icm45600/inv_icm45600_buffer.c b/drivers/iio/imu/inv_icm45600/inv_icm45600_buffer.c
> index 2efcc177f9d60a6a2509e448c0ddaf4b9e1fd755..2b9ea317385ceb680f013c4c1b2a6a74fbe5d7e7 100644
> --- a/drivers/iio/imu/inv_icm45600/inv_icm45600_buffer.c
> +++ b/drivers/iio/imu/inv_icm45600/inv_icm45600_buffer.c
> @@ -370,6 +370,7 @@ static int inv_icm45600_buffer_postdisable(struct iio_dev *indio_dev)
>  		return -EINVAL;
>  	}
>  
> +	sleep = 0;
>  	scoped_guard(mutex, &st->lock)
>  		ret = _inv_icm45600_buffer_postdisable(st, sensor, watermark, &sleep);
>  
> 
> ---
> base-commit: 70437bbd7529e9860fb7f0c92a89e0e6abaa994e
> change-id: 20251031-icm45600_fix_buffer_sleep_init-8062f6e07f84
> 
> Best regards,