linux-kernel - Re: [PATCH v2 2/2] iio: adc: Add support for TI ADS1120

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aRDJ5ugv8xJzbxTW@smile.fi.intel.com>
Date: Sun, 9 Nov 2025 19:05:42 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Ajith Anandhan <ajithanandhan0406@...il.com>
Cc: jic23@...nel.org, dlechner@...libre.com, nuno.sa@...log.com,
	andy@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] iio: adc: Add support for TI ADS1120

On Sun, Nov 09, 2025 at 07:03:56PM +0200, Andy Shevchenko wrote:
> On Sun, Nov 09, 2025 at 07:41:19PM +0530, Ajith Anandhan wrote:

...

> Many are still missing... Please, follow IWYU principle.
> 
> > +#include <linux/bitfield.h>
> > +#include <linux/cleanup.h>
> > +#include <linux/delay.h>
> 
> > +#include <linux/device.h>
> 
> Not see why you need this and not
> 
> dev_printk.h
> device/devres.h

Actually even devres.h is not needed if I did not miss anything.

> instead.
> 
> > +#include <linux/err.h>
> > +#include <linux/module.h>
> > +#include <linux/regmap.h>
> > +#include <linux/spi/spi.h>
> > +#include <linux/unaligned.h>

...

Overall looks much better than previous version.

-- 
With Best Regards,
Andy Shevchenko