linux-kernel - Re: [PATCH RFC 8/8] media: qcom: camss: Remove D-PHY-only endpoint restriction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DE4C6HV76V5M.1I1NJB2JCK1LN@fairphone.com>
Date: Sun, 09 Nov 2025 18:22:50 +0100
From: "Luca Weiss" <luca.weiss@...rphone.com>
To: <david@...t.cz>, "Robert Foss" <rfoss@...nel.org>, "Todor Tomov"
 <todor.too@...il.com>, "Bryan O'Donoghue" <bryan.odonoghue@...aro.org>,
 "Vladimir Zapolskiy" <vladimir.zapolskiy@...aro.org>, "Mauro Carvalho
 Chehab" <mchehab@...nel.org>, "Luca Weiss" <luca.weiss@...rphone.com>,
 "Petr Hodina" <phodina@...tonmail.com>, "Casey Connolly"
 <casey.connolly@...aro.org>, "Dr. Git" <drgitx@...il.com>
Cc: "Joel Selvaraj" <foss@...lselvaraj.com>, <linux-media@...r.kernel.org>,
 <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <phone-devel@...r.kernel.org>
Subject: Re: [PATCH RFC 8/8] media: qcom: camss: Remove D-PHY-only endpoint
 restriction

On Sun Nov 9, 2025 at 10:39 AM CET, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@...t.cz>
>
> C-PHY mode is now supported, so the endpoint bus-type restriction to
> D-PHY can be removed.
>
> Signed-off-by: David Heidelberg <david@...t.cz>
> ---
>  drivers/media/platform/qcom/camss/camss.c | 9 ---------
>  1 file changed, 9 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
> index 248aa6b21b5ad..1408e8a03f0bd 100644
> --- a/drivers/media/platform/qcom/camss/camss.c
> +++ b/drivers/media/platform/qcom/camss/camss.c
> @@ -4044,15 +4044,6 @@ static int camss_of_parse_endpoint_node(struct device *dev,
>  	if (ret)
>  		return ret;
>  
> -	/*
> -	 * Most SoCs support both D-PHY and C-PHY standards, but currently only
> -	 * D-PHY is supported in the driver.
> -	 */
> -	if (vep.bus_type != V4L2_MBUS_CSI2_DPHY) {

How about just adding && != V4L2_MBUS_CSI2_CPHY to it? Good to check in
any case imo.

Regards
Luca

> -		dev_err(dev, "Unsupported bus type %d\n", vep.bus_type);
> -		return -EINVAL;
> -	}
> -
>  	csd->interface.csiphy_id = vep.base.port;
>  
>  	mipi_csi2 = &vep.bus.mipi_csi2;