linux-kernel - Re: [PATCH] ublk: remove unnecessary checks in ublk_check_and_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cd973fc3-cac2-4bc8-8c58-1d06631a781e@nvidia.com>
Date: Sun, 9 Nov 2025 17:58:47 +0000
From: Chaitanya Kulkarni <chaitanyak@...dia.com>
To: Caleb Sander Mateos <csander@...estorage.com>, Ming Lei
	<ming.lei@...hat.com>, Jens Axboe <axboe@...nel.dk>
CC: "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ublk: remove unnecessary checks in
 ublk_check_and_get_req()

On 11/8/25 14:17, Caleb Sander Mateos wrote:
> ub = iocb->ki_filp->private_data cannot be NULL, as it's set in
> ublk_ch_open() before it returns succesfully. req->mq_hctx cannot be
> NULL as any inflight ublk request must belong to some queue. And
> req->mq_hctx->driver_data cannot be NULL as it's set to the ublk_queue
> pointer in ublk_init_hctx(). So drop the unnecessary checks.
>
> Signed-off-by: Caleb Sander Mateos<csander@...estorage.com>
> ---

Indeed, Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>

-ck