linux-kernel - Re: [PATCH v2 0/5] CPPC/amd-pstate: Fixes to limit actions to online CPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM+eXpe1inRG9Rbb7y=tGOWrKrQ0nnXut09MEtXwwV35Zc-tCw@mail.gmail.com>
Date: Sat, 8 Nov 2025 20:04:40 -0800
From: Chris Harris <chris.harris79@...il.com>
To: "Rafael J. Wysocki" <rafael@...nel.org>
Cc: "Gautham R. Shenoy" <gautham.shenoy@....com>, Len Brown <lenb@...nel.org>, 
	Mario Limonciello <mario.limonciello@....com>, Yunhui Cui <cuiyunhui@...edance.com>, 
	Jeremy Linton <jeremy.linton@....com>, Viresh Kumar <viresh.kumar@...aro.org>, 
	Ionela Voinescu <ionela.voinescu@....com>, linux-acpi@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH v2 0/5] CPPC/amd-pstate: Fixes to limit actions to online CPUs

Hi, I've tested all five v2 patches and have observed no issues in the
use case the bug report was based upon.  I continue to successfully
receive the desired amd-pstate scaling driver when 'nosmt=force' and
'amd_pstate=passive' are set.  I've not tested other cases/scenarios
for which the additional hardening/patches may have been intended.

Thank you again for the rapid efforts that went into this solution.

Chris Harris

On Fri, Nov 7, 2025 at 9:41 AM Rafael J. Wysocki <rafael@...nel.org> wrote:
>
> Hi,
>
> On Fri, Nov 7, 2025 at 8:42 AM Gautham R. Shenoy <gautham.shenoy@....com> wrote:
> >
> > Hello,
> >
> > This is the v2 of the patchset to restrict certain actions to only
> > online CPUs instead of present CPUs.
> >
> > The v1 of this patchset can be found here:
> > https://lore.kernel.org/lkml/20251105143851.4251-1-gautham.shenoy@amd.com/
> >
> > Changes between v1 --> v2:
> >
> >  * Picked up the Reviewed-by tags from Mario for the first four
> >    patches
> >
> >  * Picked up the Tested-by tags from Chris for the first two patches
> >
> >  * Added a fifth patch to fix calling of cppc_set_auto_sel() for only
> >    online CPUs in the amd-pstate driver code (Mario)
> >
> >
> > Gautham R. Shenoy (5):
> >   ACPI: CPPC: Detect preferred core availability on online CPUs
> >   ACPI: CPPC: Check _CPC validity for only the online CPUs
> >   ACPI: CPPC: Perform fast check switch only for online CPUs
> >   ACPI: CPPC: Limit perf ctrs in PCC check only to online CPUs
>
> The above 4 patches applied as 6.18-rc material.
>
> >   cpufreq/amd-pstate: Call cppc_set_auto_sel() only for online CPUs
>
> And I'm leaving this one to Mario.
>
> Thanks!