linux-kernel - Re: [PATCH v2] pinctrl: cirrus: Fix fwnode leak in cs42l43_pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbwzEG8fEO7mbgXTW3nn4rLUJUidHW7GJ+-OWYtch8PNA@mail.gmail.com>
Date: Mon, 10 Nov 2025 00:01:47 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Haotian Zhang <vulab@...as.ac.cn>
Cc: David Rhodes <david.rhodes@...rus.com>, Richard Fitzgerald <rf@...nsource.cirrus.com>, 
	Charles Keepax <ckeepax@...nsource.cirrus.com>, linux-sound@...r.kernel.org, 
	patches@...nsource.cirrus.com, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] pinctrl: cirrus: Fix fwnode leak in cs42l43_pin_probe()

On Tue, Oct 28, 2025 at 4:06 AM Haotian Zhang <vulab@...as.ac.cn> wrote:

> The driver calls fwnode_get_named_child_node() which takes a reference
> on the child node, but never releases it, which causes a reference leak.
>
> Fix by using devm_add_action_or_reset() to automatically release the
> reference when the device is removed.
>
> Fixes: d5282a539297 ("pinctrl: cs42l43: Add support for the cs42l43")
> Suggested-by: Charles Keepax <ckeepax@...nsource.cirrus.com>
> Signed-off-by: Haotian Zhang <vulab@...as.ac.cn>

Patch applied.

Yours,
Linus Walleij