linux-kernel - Re: [PATCH v2 13/12] nova-core: sequencer: Refactor run() to handle unknown messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DE52C66F2TU3.1SL57EIBN2X78@nvidia.com>
Date: Mon, 10 Nov 2025 22:52:43 +0900
From: "Alexandre Courbot" <acourbot@...dia.com>
To: "Joel Fernandes" <joelagnelf@...dia.com>,
 <linux-kernel@...r.kernel.org>, <rust-for-linux@...r.kernel.org>,
 <dri-devel@...ts.freedesktop.org>, <dakr@...nel.org>, <acourbot@...dia.com>
Cc: "Alistair Popple" <apopple@...dia.com>, "Miguel Ojeda"
 <ojeda@...nel.org>, "Alex Gaynor" <alex.gaynor@...il.com>, "Boqun Feng"
 <boqun.feng@...il.com>, "Gary Guo" <gary@...yguo.net>,
 <bjorn3_gh@...tonmail.com>, "Benno Lossin" <lossin@...nel.org>, "Andreas
 Hindborg" <a.hindborg@...nel.org>, "Alice Ryhl" <aliceryhl@...gle.com>,
 "Trevor Gross" <tmgross@...ch.edu>, "David Airlie" <airlied@...il.com>,
 "Simona Vetter" <simona@...ll.ch>, "Maarten Lankhorst"
 <maarten.lankhorst@...ux.intel.com>, "Maxime Ripard" <mripard@...nel.org>,
 "Thomas Zimmermann" <tzimmermann@...e.de>, "John Hubbard"
 <jhubbard@...dia.com>, "Timur Tabi" <ttabi@...dia.com>,
 <joel@...lfernandes.org>, "Daniel Almeida" <daniel.almeida@...labora.com>,
 <nouveau@...ts.freedesktop.org>, "Nouveau"
 <nouveau-bounces@...ts.freedesktop.org>
Subject: Re: [PATCH v2 13/12] nova-core: sequencer: Refactor run() to handle
 unknown messages

Hi Joel,

On Wed Nov 5, 2025 at 8:26 AM JST, Joel Fernandes wrote:
> Refactor GspSequencer::run() to follow the same pattern as gsp_init_done()
> by wrapping message reception in a loop that ignores unknown messages
> (ERANGE errors).

Can you squash this code into the appropriate patch when you respin the
series?

>
> Suggested-by: Timur Tabi <ttabi@...dia.com>
> Signed-off-by: Joel Fernandes <joelagnelf@...dia.com>
> ---
> Additional patch to cure probe issue on Timur's GA102 (which happens to receive
> too many NOCAT records).
>
>  drivers/gpu/nova-core/gsp/sequencer.rs | 86 +++++++++++++++-----------
>  1 file changed, 49 insertions(+), 37 deletions(-)
>
> diff --git a/drivers/gpu/nova-core/gsp/sequencer.rs b/drivers/gpu/nova-core/gsp/sequencer.rs
> index ecc80f668dc8..b98e5146abd8 100644
> --- a/drivers/gpu/nova-core/gsp/sequencer.rs
> +++ b/drivers/gpu/nova-core/gsp/sequencer.rs
> @@ -35,8 +35,8 @@ impl MessageFromGsp for fw::rpc_run_cpu_sequencer_v17_00 {
>  
>  const CMD_SIZE: usize = size_of::<fw::GSP_SEQUENCER_BUFFER_CMD>();
>  
> -struct GspSequencerInfo<'a> {
> -    info: &'a fw::rpc_run_cpu_sequencer_v17_00,
> +struct GspSequencerInfo {
> +    cmd_index: u32,
>      cmd_data: KVec<u8>,
>  }
>  
> @@ -125,7 +125,7 @@ pub(crate) fn size_bytes(&self) -> usize {
>  }
>  
>  pub(crate) struct GspSequencer<'a> {
> -    seq_info: GspSequencerInfo<'a>,
> +    seq_info: GspSequencerInfo,

I've looked at how `GspSequencere`, `GspSequencerParams` and
`GspSequencerInfo` interact after this patch, and I think we can
simplify the design a bit (based on the v9 of the GSP boot series).

`GspSequencerInfo` is actually the sequence (so we should name it
`GspSequence`?) we want to run. As such, it can be created by
implementing the `MessageFromGsp` trait, and received directly from
`boot.rs` by moving the loop at the beginning of `GspSequencer::run` to
`boot.rs`. This allows to remove the `cmdq` argument from the `run`
method, which looked a bit out of place.

In its place, we can pass the sequence to `run`. It doesn't need to be
stored in the `GspSequencer` struct, as we can just implement `Iterator`
on it and read its commands from `run` directly. Once you remove it from
`GspSequencer`, something interesting happens: `GspSequencer` and
`GspSequencerParams` are now exactly the same! So we can remove the
params, simply build the sequencer using a regular constructor, and call
`run` on it with the sequence.