linux-kernel - Re: [PATCH] clk: spacemit: fix comment typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251110141251-GYD1651402@gentoo.org>
Date: Mon, 10 Nov 2025 22:12:51 +0800
From: Yixun Lan <dlan@...too.org>
To: Encrow Thorne <jyc0019@...il.com>
Cc: Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>, linux-clk@...r.kernel.org,
	linux-riscv@...ts.infradead.org, spacemit@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: spacemit: fix comment typo

Hi Encrow,

On 06:33 Thu 30 Oct     , Yixun Lan wrote:
> Hi Encrow,
> 
> On 00:05 Wed 29 Oct     , Encrow Thorne wrote:
> > ccumix.h was copied from ccudiv.h and the comment after #endif was not
> > updated.
> > 
> > This patch fixes the incorrect comment to match the filename.
> 
> Just describe in imperative mode, see
> (since this is trivial, I could amend it before apply the patch,
> so no need to resend)
> https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94
> 
I have no other clock patch queued this cycle, so how about you respin a v2
then let's ping Stephen directly for inclusion?

for commit message, I'd suggest simply as below (short/clean, also enough):

Fix incorrect comment to match the filename.

> > 
> > Signed-off-by: Encrow Thorne <jyc0019@...il.com>
> > ---
> >  drivers/clk/spacemit/ccu_mix.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/clk/spacemit/ccu_mix.h b/drivers/clk/spacemit/ccu_mix.h
> > index 54d40cd39b27..c406508e3504 100644
> > --- a/drivers/clk/spacemit/ccu_mix.h
> > +++ b/drivers/clk/spacemit/ccu_mix.h
> > @@ -220,4 +220,4 @@ extern const struct clk_ops spacemit_ccu_div_gate_ops;
> >  extern const struct clk_ops spacemit_ccu_mux_gate_ops;
> >  extern const struct clk_ops spacemit_ccu_mux_div_ops;
> >  extern const struct clk_ops spacemit_ccu_mux_div_gate_ops;
> > -#endif /* _CCU_DIV_H_ */
> > +#endif /* _CCU_MIX_H_ */
> > 
> > ---
> > base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
> > change-id: 20251028-b4-fix-ccu-mix-typo-038c19fe30c4
> > 
> > Best regards,
> > -- 
> > Encrow Thorne <jyc0019@...il.com>
> > 
> 
> -- 
> Yixun Lan (dlan)
> 

-- 
Yixun Lan (dlan)