linux-kernel - Re: [PATCH v2 09/13] dmaengine: qcom: adm: use sg_nents_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6h44m3aoqaitosivcbnuz2ynhon2de3vpxk6egz54vgfqxnsgi@ykhk73irtfcv>
Date: Mon, 10 Nov 2025 09:07:16 -0600
From: Bjorn Andersson <andersson@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Stefan Wahren <wahrenst@....net>, Vinod Koul <vkoul@...nel.org>, 
	Thomas Andreatta <thomasandreatta2000@...il.com>, Caleb Sander Mateos <csander@...estorage.com>, 
	dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-rpi-kernel@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org, 
	linux-arm-msm@...r.kernel.org, Olivier Dautricourt <olivierdautricourt@...il.com>, 
	Stefan Roese <sr@...x.de>, Florian Fainelli <florian.fainelli@...adcom.com>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Ray Jui <rjui@...adcom.com>, 
	Scott Branden <sbranden@...adcom.com>, Lars-Peter Clausen <lars@...afoo.de>, 
	Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>, Daniel Mack <daniel@...que.org>, 
	Haojian Zhuang <haojian.zhuang@...il.com>, Robert Jarzmik <robert.jarzmik@...e.fr>, 
	Lizhi Hou <lizhi.hou@....com>, Brian Xu <brian.xu@....com>, 
	Raj Kumar Rampelli <raj.kumar.rampelli@....com>, Michal Simek <michal.simek@....com>, 
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v2 09/13] dmaengine: qcom: adm: use sg_nents_for_dma()
 helper

On Mon, Nov 10, 2025 at 11:23:36AM +0100, Andy Shevchenko wrote:
> Instead of open coded variant let's use recently introduced helper.
> 

Reviewed-by: Bjorn Andersson <andersson@...nel.org>

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/dma/qcom/qcom_adm.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/dma/qcom/qcom_adm.c b/drivers/dma/qcom/qcom_adm.c
> index 6be54fddcee1..490edad20ae6 100644
> --- a/drivers/dma/qcom/qcom_adm.c
> +++ b/drivers/dma/qcom/qcom_adm.c
> @@ -390,16 +390,15 @@ static struct dma_async_tx_descriptor *adm_prep_slave_sg(struct dma_chan *chan,
>  	}
>  
>  	/* iterate through sgs and compute allocation size of structures */
> -	for_each_sg(sgl, sg, sg_len, i) {
> -		if (achan->slave.device_fc) {
> +	if (achan->slave.device_fc) {
> +		for_each_sg(sgl, sg, sg_len, i) {
>  			box_count += DIV_ROUND_UP(sg_dma_len(sg) / burst,
>  						  ADM_MAX_ROWS);
>  			if (sg_dma_len(sg) % burst)
>  				single_count++;
> -		} else {
> -			single_count += DIV_ROUND_UP(sg_dma_len(sg),
> -						     ADM_MAX_XFER);
>  		}
> +	} else {
> +		single_count = sg_nents_for_dma(sgl, sg_len, ADM_MAX_XFER);
>  	}
>  
>  	async_desc = kzalloc(sizeof(*async_desc), GFP_NOWAIT);
> -- 
> 2.50.1
> 
>