linux-kernel - Re: [PATCH 1/5] s390/ipl: Mark store_status as _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251110150635.15528B2f-hca@linux.ibm.com>
Date: Mon, 10 Nov 2025 16:06:35 +0100
From: Heiko Carstens <hca@...ux.ibm.com>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>, linux-s390@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] s390/ipl: Mark store_status as __noreturn

On Mon, Nov 10, 2025 at 02:27:51PM +0100, Thorsten Blum wrote:
> store_status() performs a tail call (BR_EX) to the function passed as
> the first parameter and does not return. Annotate the declaration with
> the __noreturn attribute to improve compiler optimizations.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
>  arch/s390/include/asm/ipl.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This doesn't make any sense. If a function is called, which calls
another one with a tail call, then _of course_ it looks to the caller
like the function returned.