linux-kernel - Re: [PATCH v1 2/3] arm64: dts: ti: Add Aquila AM69 Support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e1b2a13d-fab0-47f1-aae3-f2661c94d54a@ti.com>
Date: Mon, 10 Nov 2025 10:06:58 +0530
From: Vignesh Raghavendra <vigneshr@...com>
To: Francesco Dolcini <francesco@...cini.it>, Andrew Davis <afd@...com>
CC: Nishanth Menon <nm@...com>, Tero Kristo <kristo@...nel.org>, Rob Herring
	<robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
	<conor+dt@...nel.org>, Parth Pancholi <parth.pancholi@...adex.com>,
	<linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, Emanuele Ghidoli
	<emanuele.ghidoli@...adex.com>, Ernest Van Hoecke
	<ernest.vanhoecke@...adex.com>, João Paulo Gonçalves
	<joao.goncalves@...adex.com>, Francesco Dolcini
	<francesco.dolcini@...adex.com>
Subject: Re: [PATCH v1 2/3] arm64: dts: ti: Add Aquila AM69 Support

Hi Francesco,

On 06/11/25 15:49, Francesco Dolcini wrote:
>>> Yes, known. Is this an issue?
>>>
>>> This node must be disabled, no matter what is present in any included
>>> dtsi file, it's a deliberate decision.
>>>
>>> This dtsi file describes a SoM, the used pins/functions are defined on
>>> the pinout, but this node cannot be enabled unless the SoM is mated with
>>> a carrier board that is exposing it.
>> Same as my point above, you shouldn't enable nodes that are not used
>> or have anything attached. The SoM only has some edge connectors so
>> it should not be enabled at the SoM level, that we seem to agree, but
>> the carrier board doesn't connect those lines to anything either. They
>> just run to a pin header with nothing attached, how is that header
>> any different than the pins on the edge of the SoM?
> You are commenting something unrelated here, or I am not understanding
> you.
> 
> You commented that the status = "disabled" is redundant. We both agree
> that this node needs to be disabled in the SoM dtsi, and it is already
> like that.
> 
> I would prefer to keep the redundant "disabled", because I see value on
> not having to rely on what is done on any included dtsi, where the
> original node is defined. 


One can always reverse compile the DTB to see if a node is enabled or not.

> I see this as a common pattern in multiple
> dts/dtsi file and is what I would prefer to have (and I do not see any
> kind of maintenance  overhead on having it nor this being in conflict
> with dts-coding-style.rst).

I cannot seem to find any precedence to such a pattern (adding status =
"disabled" for nodes that are already disabled at SoC level dtsi.) Could
you point me to some?

> 
> Vignesh, Nishanth, what is your expectation on this redundant
> `status = "disabled"` property?
> 	

Assuming such pattern exists, please add a note in the commit message in
the next version.

> Francesco
> 

-- 
Regards
Vignesh
https://ti.com/opensource