linux-kernel - Re: linux-next: manual merge of the pwm tree with the modules tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <26c7zdxc4nv3wx25xferlggtjipigtd3tc6fk554g4tmqsuvmr@e6cll772nz2r>
Date: Mon, 10 Nov 2025 16:42:39 +0100
From: Uwe Kleine-König <ukleinek@...nel.org>
To: Daniel Gomez <da.gomez@...nel.org>
Cc: Daniel Gomez <da.gomez@...sung.com>, 
	Luis Chamberlain <mcgrof@...nel.org>, Stephen Rothwell <sfr@...b.auug.org.au>, 
	Sami Tolvanen <samitolvanen@...gle.com>, Petr Pavlu <petr.pavlu@...e.com>, 
	Andreas Hindborg <a.hindborg@...nel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, 
	Linux Next Mailing List <linux-next@...r.kernel.org>, Michal Wilczynski <m.wilczynski@...sung.com>
Subject: Re: linux-next: manual merge of the pwm tree with the modules tree

Hello Daniel,

On Mon, Nov 10, 2025 at 02:59:15PM +0100, Daniel Gomez wrote:
> On 07/11/2025 17.44, Uwe Kleine-König wrote:
> > Hi Daniel,
> > 
> > On Tue, Nov 04, 2025 at 10:54:15AM +1100, Stephen Rothwell wrote:
> >> [adding the modules tree contacts]
> >>
> >> On Tue, 4 Nov 2025 10:48:27 +1100 Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> >>>
> >>> Today's linux-next merge of the pwm tree got a conflict in:
> >>>
> >>>   rust/macros/module.rs
> >>>
> >>> between commits:
> >>>
> >>>   3809d7a89fe5 ("rust: module: use a reference in macros::module::module")
> >>>   0b24f9740f26 ("rust: module: update the module macro with module parameter support")
> >>>
> >>> from the modules tree and commit:
> >>>
> >>>   927687809649 ("rust: macros: Add support for 'imports_ns' to module!")
> > 
> > I reshuffled my tree such that the import_ns commit sits directly on top
> > of 6.18-rc1. The new commit-id is 739ad9be61e5.
> > 
> >>> from the pwm tree.
> >>> [...]
> >>>  -    if let Some(imports) = info.imports_ns {
> >>> ++    if let Some(imports) = &info.imports_ns {
> >>> +         for ns in imports {
> >>> +             modinfo.emit("import_ns", &ns);
> >>> +         }
> >>> +     }
> > 
> > Given that the conflict resolution is non-trivial and we already know
> > what to do, I suggest you merge my commit into the modules tree.
> 
> Do you mean creating a separate branch that includes the conflict resolution, to
> be used as an example when sending the PR?

If I were the module maintainer I'd pull

	https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git rust-module-namespace

into my tree and include that into the v6.19-rc1 pull request. That way
the merge conflict doesn't happen at all for Linus.

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)