linux-kernel - Re: [PATCH bpf] bpf: handle the return of ftrace_set_filter_ip in register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHzjS_vj26p7SwVupAb0XyTZs__NProJ+CN6DKy+-E1R+Wk33Q@mail.gmail.com>
Date: Mon, 10 Nov 2025 07:49:18 -0800
From: Song Liu <song@...nel.org>
To: Menglong Dong <menglong8.dong@...il.com>
Cc: ast@...nel.org, song@...nel.org, daniel@...earbox.net, 
	john.fastabend@...il.com, andrii@...nel.org, martin.lau@...ux.dev, 
	eddyz87@...il.com, yonghong.song@...ux.dev, kpsingh@...nel.org, 
	sdf@...ichev.me, haoluo@...gle.com, jolsa@...nel.org, jiang.biao@...ux.dev, 
	bpf@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH bpf] bpf: handle the return of ftrace_set_filter_ip in register_fentry

On Mon, Nov 10, 2025 at 4:07 AM Menglong Dong <menglong8.dong@...il.com> wrote:
>
> The error that returned by ftrace_set_filter_ip() in register_fentry() is
> not handled properly. Just fix it.
>
> Fixes: 00963a2e75a8 ("bpf: Support bpf_trampoline on functions with IPMODIFY (e.g. livepatch)")
> Signed-off-by: Menglong Dong <dongml2@...natelecom.cn>
> ---
>  kernel/bpf/trampoline.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

LGTM. Thanks for the fix!

Acked-by: Song Liu <song@...nel.org>

Can we add a test for this code path?

Song