linux-kernel - Re: [PATCH] i3c: master: add WQ_PERCPU to alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aRIaQOQkbPOFpJM+@lizhi-Precision-Tower-5810>
Date: Mon, 10 Nov 2025 12:00:48 -0500
From: Frank Li <Frank.li@....com>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc: Marco Crivellari <marco.crivellari@...e.com>,
	linux-kernel@...r.kernel.org, linux-i3c@...ts.infradead.org,
	Tejun Heo <tj@...nel.org>, Lai Jiangshan <jiangshanlai@...il.com>,
	Frederic Weisbecker <frederic@...nel.org>,
	Michal Hocko <mhocko@...e.com>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>
Subject: Re: [PATCH] i3c: master: add WQ_PERCPU to alloc_workqueue users

On Fri, Nov 07, 2025 at 11:28:30PM +0100, Sebastian Andrzej Siewior wrote:
> On 2025-11-07 16:00:06 [-0500], Frank Li wrote:
> > > diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
> > > index d946db75df70..519b98c37ac7 100644
> > > --- a/drivers/i3c/master.c
> > > +++ b/drivers/i3c/master.c
> > > @@ -2925,7 +2925,7 @@ int i3c_master_register(struct i3c_master_controller *master,
> > >  	if (ret)
> > >  		goto err_put_dev;
> > >
> > > -	master->wq = alloc_workqueue("%s", 0, 0, dev_name(parent));
> > > +	master->wq = alloc_workqueue("%s", WQ_PERCPU, 0, dev_name(parent));
> >
> > Maybe off topic, I think it is not neccesary to create wq for IBI at all.
> > it can directly use system_bh_wq, or other wq.
>
> Do you really meant system_bh_wq or would system_unbound_wq do the job?
> The _bh_ one would imply softirq usage, I don't think you want that.

My major means is that not neccessary to alloc a work queue for IBI. Use
one of system predefined should be enough. system_unbound_wq is good
candidate.

Your change is also good, let's wait for more reviewer's comments.

Frank

>
> > Frank
>
> Sebastian