linux-kernel - Re: [PATCH 1/3] staging: rtl8723bs: Rename camel case enumeration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aRIfq9sDa2Neok1W@ubuntu-desk>
Date: Mon, 10 Nov 2025 17:24:02 +0000
From: Bryant Boatright <bryant.boatright@...ton.me>
To: Michael Straube <straube.linux@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] staging: rtl8723bs: Rename camel case enumeration

On Sat, Nov 08, 2025 at 06:51:45AM +0100, Michael Straube wrote:
> Hi Bryant,
> 
> Am 08.11.25 um 05:54 schrieb Bryant Boatright:
> > -enum ParseRes { ParseOK = 0, ParseUnknown = 1, ParseFailed = -1 };
> > +enum parse_res { parse_ok = 0, parse_unknown = 1, parse_failed = -1 };
> 
> The constants in enums are usually named all upper case.
> PARSE_OK, PARSE_UNKNOWN, PARSE_FAILED
> 
> Best regards,
> Michael

Michael,

Thanks for the feedback, I'll correct that and resubmit in a
V2 patchset.

Best,
Bryant